Skip to content

[Doc]: ncols parameter hard-coded #26560

Closed

Description

@fostermaier

Documentation Link

https://matplotlib.org/stable/gallery/color/named_colors.html

Problem

I just copied the example code and changed the number of columns ncols.
It seems there are some hard coded 4s in the code.

Suggested improvement

change 4 s in

width = cell_width * 4 + 2 * margin

and
ax.set_xlim(0, cell_width * 4)

to ncols

Activity

  1. rcomer commented on Aug 21, 2023

    @rcomer
    Member

    Good spot @fostermaier! Would you like to make a pull request to fix it?

  2. added
    🌱 Good first issueOpen a pull request against these issues if there are no active ones!
    on Aug 21, 2023
  3. github-actions commented on Aug 21, 2023

    @github-actions

    Good first issue - notes for new contributors

    This issue is suited to new contributors because it does not require understanding of the Matplotlib internals. To get started, please see our contributing guide.

    We do not assign issues. Check the Development section in the sidebar for linked pull requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please collaborate on the work by reviewing it rather than duplicating it in a competing PR.

    If something is unclear, please reach out on any of our communication channels.

  4. AmirAflak commented on Aug 21, 2023

    @AmirAflak
    Contributor

    would like to take this :)

  5. added this to the v3.7.3 milestone on Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Documentation🌱 Good first issueOpen a pull request against these issues if there are no active ones!

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions