You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think yes, if you give me a link to some tutorial. I am novice here and don't know what type of regression test you want, and what and where write about what's new (do you mean just add new input parameter in function comment?)
Back compatibility seems obvious, if counterclock is True, new code works just like old one.
Your english is too good for me, sorry, I can not understand precisely what are you asking for.
This code works good in my project, diff looks quite simple. If I shall do something to help you include this code in 1.4.0, tell me please what shall I do.
Do you know how to use git/github well enough to create a pull request?
There is a file in the documentation folder whats_new.rst which should have a description of this change added. For the test, basically copy one of the existing image tests.
If you can please make a pull request. If not then I will take care of this.
Activity
mdboom commentedon Oct 23, 2013
Can you add a regression test and a what's new entry?
fat-crocodile commentedon Oct 23, 2013
I think yes, if you give me a link to some tutorial. I am novice here and don't know what type of regression test you want, and what and where write about what's new (do you mean just add new input parameter in function comment?)
Back compatibility seems obvious, if counterclock is True, new code works just like old one.
tacaswell commentedon Feb 26, 2014
@fat-crocodile Have you been able to work in this? It would be nice to get this into 1.4.0.
fat-crocodile commentedon Feb 26, 2014
Your english is too good for me, sorry, I can not understand precisely what are you asking for.
This code works good in my project, diff looks quite simple. If I shall do something to help you include this code in 1.4.0, tell me please what shall I do.
tacaswell commentedon Feb 26, 2014
Do you know how to use git/github well enough to create a pull request?
There is a file in the documentation folder
whats_new.rstwhich should have a description of this change added. For the test, basically copy one of the existing image tests.If you can please make a pull request. If not then I will take care of this.
fat-crocodile commentedon Feb 28, 2014
#2853
tacaswell commentedon Mar 8, 2014
Closing this in favor of the open PR (#2853)