Skip to content

[CI]: eslint failure #25251

Closed
Closed

Description

@scottshambaugh

Summary

Recent PRs are failing eslint linter checks with the following:

Run reviewdog/action-eslint@v1
Run $GITHUB_ACTION_PATH/script.sh
🐶 Installing reviewdog ... https://github.com/reviewdog/reviewdog
 Running `npm install` to install eslint ...
eslint version:
/home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 20: Unknown: not found
 Running eslint with reviewdog 🐶 ...
  /home/runner/work/_actions/reviewdog/action-eslint/v1/script.sh: 23: Unknown: not found
reviewdog: failed to unmarshal rdjson (DiagnosticResult): proto: syntax error (line 1:1): unexpected token 
Error: Process completed with exit code 1.

Looks related to this: reviewdog/action-eslint#152

Proposed fix

The above issues proposes a workaround with:

      - uses: actions/setup-node@v3
         with:
           node-version: '18.13'
           cache: 'yarn'

However I’m unclear if pinning that version is best practice.

Activity

  1. robrighter commented on Feb 19, 2023

    @robrighter
    Contributor

    I feel like it would be reasonable to apply this workaround for now and also create a separate issue to remove the workaround when v9 support is added.

  2. added this to the v3.7.1 milestone on Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    CI: testingCI configuration and testing

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions