Skip to content

Add note in contrib guide admonishing against use of f strings in logs #25080

Closed

Description

@jklymak

Can a note about this be put somewhere on the contributing code page? I worry that this is the type of thing that will get changed in either direction 16 times.

Originally posted by @story645 in #25073 (comment)

Activity

  1. modified the milestones: v3.7-doc, v3.8.0 on Jan 25, 2023
  2. linked a pull request that will close this issueadded a note to avoid f-strings in logging #25081on Jan 25, 2023
  3. neutrinoceros commented on Jan 26, 2023

    @neutrinoceros
    Contributor

    How about using flake8-logging-format ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Documentation🌱 Good first issueOpen a pull request against these issues if there are no active ones!

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions