You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
legends don't traverse every artist and look for labels. Low-level objects that need something like add_foo usually are not part of the legend. I personally think that is fine - if you have to do add_foo you are doing something relatively low level, and can be expected to manually add the artist to the legend.
write a PatchCollectionHandler in matplotlib.legend_handlers. As with other collections this should use the properties of the first patch in the collection. Take inspiration from
HandlerPatch to see how a Patch is handled
HandlerLineCollection to see how a handler for a collection works
I have created a draft pull request. However, since this is my first contribution to an open source project, I am not sure on how to document it. I would appreciate some help :)
Any way I can help with this? I am new to programming and new to open source so I might need some help. I have worked with matplotlib before very briefly.
Any way I can help with this? I am new to programming and new to open source so I might need some help. I have worked with matplotlib before very briefly.
I will probably finish these changes tomorrow. I would recommend doing another ticket since I’m almost done. However, I’m also new to open source, if you want, we can learn together? After this issue, I will try to tackle another issues, feel free to reach out to me if I can be of any help :)
This might be a long shot, but would you be willing to possibly meet with me virtually and we could work on it together at some point tomorrow? I picked this particular issue for a class assignment at school and I'd really like to contribute to this one in any way I can if it's still possible. No worries either way, I just definitely need some help getting started with open-source :)
This might be a long shot, but would you be willing to possibly meet with me virtually and we could work on it together at some point tomorrow? I picked this particular issue for a class assignment at school and I'd really like to contribute to this one in any way I can if it's still possible. No worries either way, I just definitely need some help getting started with open-source :)
I am using this for UF's open source assignment as I commented before FarukFS, but noticed he did a pull request first. I am submitting a pull request tonight for the sake of the assignment when I get wifi on my laptop just so you know if you are also trying to use this for that assignment!
Oh wow yes I am also trying to use this for the UF open source assignment. I would really love to understand how the bug is fixed though so that I can make a meaningful pull request for experience (even if it is not accepted)
We're a mostly volunteer team and every pull request requires folks to take their time to triage and review it; while we value your contribution and hope it helps your growth as a programmer, we feel it is a far better use of everyone's time to not duplicate work.
@emmamastro and @FarukFS, do the boundaries of the assignment allow you two to collaborate on @FarukFS's PR as it is further along and already reviewed?
ETA: I am also sorry @emmamastro that you didn't get the chance to put in your PR first, but our current policy is that issues can not be claimed except by putting in a PR so @FarukFS 's PR also has priority.
@julia-harbord Sure. We can meet if you want, I can tell you about the changes that I made and why. I think that I am quite close to solving the issue, so it would probably be better to follow @story645 advice (I have some minor issues in my current PR, feel free to check it). As I said, we can meet and I can tell you a bit about the process, but don't expect too much, I'm also new :)
Activity
jklymak commentedon Sep 26, 2022
legends don't traverse every artist and look for labels. Low-level objects that need something like
add_foousually are not part of the legend. I personally think that is fine - if you have to doadd_fooyou are doing something relatively low level, and can be expected to manually add the artist to the legend.timhoffm commentedon Sep 26, 2022
I can see an argument for supporting
PatchCollection. We supportLine2D,PatchandLineCollectionin legends, so why notPatchCollection.I think this is a good first issue. What needs to be done:
PatchCollectionHandlerinmatplotlib.legend_handlers. As with other collections this should use the properties of the first patch in the collection. Take inspiration fromHandlerPatchto see how a Patch is handledHandlerLineCollectionto see how a handler for a collection worksLegend._default_handler_mapemmamastro commentedon Sep 27, 2022
I can try to take this issue!
FarukFS commentedon Sep 28, 2022
I have created a draft pull request. However, since this is my first contribution to an open source project, I am not sure on how to document it. I would appreciate some help :)
julia-harbord commentedon Sep 28, 2022
Any way I can help with this? I am new to programming and new to open source so I might need some help. I have worked with matplotlib before very briefly.
FarukFS commentedon Sep 28, 2022
I will probably finish these changes tomorrow. I would recommend doing another ticket since I’m almost done. However, I’m also new to open source, if you want, we can learn together? After this issue, I will try to tackle another issues, feel free to reach out to me if I can be of any help :)
julia-harbord commentedon Sep 29, 2022
This might be a long shot, but would you be willing to possibly meet with me virtually and we could work on it together at some point tomorrow? I picked this particular issue for a class assignment at school and I'd really like to contribute to this one in any way I can if it's still possible. No worries either way, I just definitely need some help getting started with open-source :)
emmamastro commentedon Sep 29, 2022
I am using this for UF's open source assignment as I commented before FarukFS, but noticed he did a pull request first. I am submitting a pull request tonight for the sake of the assignment when I get wifi on my laptop just so you know if you are also trying to use this for that assignment!
julia-harbord commentedon Sep 29, 2022
Oh wow yes I am also trying to use this for the UF open source assignment. I would really love to understand how the bug is fixed though so that I can make a meaningful pull request for experience (even if it is not accepted)
story645 commentedon Sep 29, 2022
@julia-harbord please look at a different issue; if you need help finding one, then please get in touch with us at one of the channels listed at https://matplotlib.org/devdocs/devel/contributing.html#get-connected
We're a mostly volunteer team and every pull request requires folks to take their time to triage and review it; while we value your contribution and hope it helps your growth as a programmer, we feel it is a far better use of everyone's time to not duplicate work.
@emmamastro and @FarukFS, do the boundaries of the assignment allow you two to collaborate on @FarukFS's PR as it is further along and already reviewed?
ETA: I am also sorry @emmamastro that you didn't get the chance to put in your PR first, but our current policy is that issues can not be claimed except by putting in a PR so @FarukFS 's PR also has priority.
FarukFS commentedon Sep 29, 2022
@julia-harbord Sure. We can meet if you want, I can tell you about the changes that I made and why. I think that I am quite close to solving the issue, so it would probably be better to follow @story645 advice (I have some minor issues in my current PR, feel free to check it). As I said, we can meet and I can tell you a bit about the process, but don't expect too much, I'm also new :)
anika3943 commentedon Apr 20, 2025
Hi, interested in working on this issue!