You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks! I think it looks good, but have limited experience with CodeQL.
What I liked about LGTM was that it also showed things that "could be better", it kept a database and didn't complain too loudly. Good thing with CodeQL (as I understand it) is that it will complain quite loudly if someone tries to introduce something really bad, but may not of the type "you could write this like that instead".
Maybe we should revisit the flake8 settings at some stage?
Activity
tacaswell commentedon Sep 6, 2022
We should get #22446 fixed up and merged.
tacaswell commentedon Sep 6, 2022
I moved the work to #23812 because I did not want to force-push to upstream (even if it was on just one branch).
oscargus commentedon Sep 7, 2022
Thanks! I think it looks good, but have limited experience with CodeQL.
What I liked about LGTM was that it also showed things that "could be better", it kept a database and didn't complain too loudly. Good thing with CodeQL (as I understand it) is that it will complain quite loudly if someone tries to introduce something really bad, but may not of the type "you could write this like that instead".
Maybe we should revisit the flake8 settings at some stage?
tacaswell commentedon Nov 30, 2022
This is closed by #23812