Skip to content

Static code analysis #23803

Closed
Closed

Description

@oscargus

Currently LGTM.com is used, but they will stop operating at the end of the year, https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/. There has been an attempt to use CodeQL #22446 but a bit more working is needed.

pylint/flake8 sorts out some of the issues though for the Python code.

Related: #17063

Should we try to get CodeQL up and running? Any other code checking tool/site worth considering?

Activity

  1. tacaswell commented on Sep 6, 2022

    @tacaswell
    Member

    We should get #22446 fixed up and merged.

  2. tacaswell commented on Sep 6, 2022

    @tacaswell
    Member

    I moved the work to #23812 because I did not want to force-push to upstream (even if it was on just one branch).

  3. oscargus commented on Sep 7, 2022

    @oscargus
    MemberAuthor

    Thanks! I think it looks good, but have limited experience with CodeQL.

    What I liked about LGTM was that it also showed things that "could be better", it kept a database and didn't complain too loudly. Good thing with CodeQL (as I understand it) is that it will complain quite loudly if someone tries to introduce something really bad, but may not of the type "you could write this like that instead".

    Maybe we should revisit the flake8 settings at some stage?

  4. tacaswell commented on Nov 30, 2022

    @tacaswell
    Member

    This is closed by #23812

  5. added this to the v3.7.0 milestone on Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions