issues with unicode_literals and pysides.QtCore.Slot #2378

Activity

1. tacaswell commented on Sep 4, 2013

   

   tacaswell

   on Sep 4, 2013

   MemberAuthor

   More actions

   also see https://code.google.com/p/spyderlib/issues/detail?id=1466 -> discussion at -https://code.google.com/p/spyderlib/source/detail?r=d12c3026caee -> https://bugreports.qt-project.org/browse/PYSIDE-100

   so it looks like this is long standing but unfixed upstream issue.
2. tacaswell commented on Sep 4, 2013

   

   tacaswell

   on Sep 4, 2013

   MemberAuthor

   More actions

   And it looks like the 'fix' is to convert all of the Qt calls to new style calls.

   If we look at the top of backend.qt4_editor/formlayout.py (which just happens to be the first place that @QtCore.Slot() is encountered when importing stuff) if we change it to:

   from __future__ import absolute_import, division, print_function, unicode_literals
   
   import six
   from six.moves import xrange
   
   # History:
   # 1.0.10: added float validator (disable "Ok" and "Apply" button when not valid)
   # 1.0.7: added support for "Apply" button
   # 1.0.6: code cleaning
   
   __version__ = '1.0.10'
   __license__ = __doc__
   
   DEBUG = False
   
   import sys
   STDERR = sys.stderr
   
   from matplotlib.colors import is_color_like
   from matplotlib.colors import rgb2hex
   from matplotlib.colors import colorConverter
   
   from matplotlib.backends.qt4_compat import QtGui, QtCore
   if not hasattr(QtGui, 'QFormLayout'):
       raise ImportError("Warning: formlayout requires PyQt4 >v4.3 or PySide")
   
   import datetime
   
   class ColorButton(QtGui.QPushButton):
       """
       Color choosing push button
       """
       # __pyqtSignals__ = ("colorChanged(QColor)",)
   
       def __init__(self, parent=None):
           QtGui.QPushButton.__init__(self, parent)
           self.setFixedSize(20, 20)
           self.setIconSize(QtCore.QSize(12, 12))
           # self.connect(self, QtCore.SIGNAL("clicked()"), self.choose_color)
           self._color = QtGui.QColor()
   
       def choose_color(self):
           color = QtGui.QColorDialog.getColor(self._color,self.parentWidget(),'')
           if color.isValid():
               self.set_color(color)
   
       def get_color(self):
           return self._color
   
       @QtCore.Slot(QtGui.QColor)
       def set_color(self, color):
           if color != self._color:
               self._color = color
               # self.emit(QtCore.SIGNAL("colorChanged(QColor)"), self._color)
               pixmap = QtGui.QPixmap(self.iconSize())
               pixmap.fill(color)
               self.setIcon(QtGui.QIcon(pixmap))
   
       color = QtCore.Property(QtGui.QColor, get_color, set_color)
   

   It does not segfault.
3. tacaswell commented on Sep 4, 2013

   

   tacaswell

   on Sep 4, 2013

   MemberAuthor

   More actions

   Sorry for having a conversation with my self, but it doesn't look too bad to (only ~34 lines need to be changed in only two files (backend_qt4.py and formlayout.py). I will take a crack at this tonight.
4. mdboom commented on Sep 4, 2013

   

   mdboom

   on Sep 4, 2013

   Member

   More actions

   Great. The change to not using 2to3 was just merged yesterday, and I'm glad it's already getting its tyres kicked, and thanks for finding a solution.
5. mdboom commented on Sep 4, 2013

   

   mdboom

   on Sep 4, 2013

   Member

   More actions

   @tacaswell: Thanks. Sorry for the speedbump, but I think we're going to prefer not running 2to3 anymore in the long run.
6. tacaswell

   added a commit that references this issue on Sep 5, 2013

   converted import-critical PyQt calls to new style so that it will

   ...

   7ddc5ee
7. tacaswell

   closed this as completedon Sep 12, 2013