Skip to content

Only upload failed images on failure #23400

Closed

Description

@tacaswell

Currently when a job fails on GHA we upload all 109 MB across ~7k files which takes a surprisingly long time. What we really want is just the images that failed and the computed difference.

This is labeled as "good first issue" because there are no API designs here (it is all configuring CI).

Steps:

  • sort out how to identify the failed test images (there is a systematic naming convention)
  • explain that to the uploader workflow (or just delete all of the non-failed fails!)

Activity

  1. added
    🌱 Good first issueOpen a pull request against these issues if there are no active ones!
    on Jul 7, 2022
  2. QuLogic commented on Jul 8, 2022

    @QuLogic
    Member

    @andrzejnovak actually did this in #19466, but we closed it when I accidentally did the upload carte-blanche in a different PR. I had some slight reservations about where the subsetting was in that PR. It seems our tests must have ballooned though, because it was only 50 MB at that point.

  3. Anika-Roy commented on Jul 13, 2022

    @Anika-Roy

    I'm a beginner and I would like to work on this.

  4. andrzejnovak commented on Jul 20, 2022

    @andrzejnovak
    Contributor

    Fine for me if someone else wants to work on this or reuse my old PR. Probably some guidance from @jklymak on the direction would be helpful.

  5. N3XT14 commented on Apr 11, 2023

    @N3XT14

    Has anyone started to work on this ?

    Would love to take it and also would like to know how can I follow the closed PR to make it work or get an Idea?

  6. tacaswell commented on Apr 11, 2023

    @tacaswell
    MemberAuthor

    @N3XT14 Please have a look at the linked PR and then ask any specific questions you have.

  7. N3XT14 commented on Apr 13, 2023

    @N3XT14

    Hi @tacaswell. I looked at the linked PR and understood it well but what I am trying to find out is the linked issue with that PR which I couldn't find.
    I need it so that I can understand where the problem is, how do I reproduce it, and then work on fixing it.

  8. andrzejnovak commented on Apr 13, 2023

    @andrzejnovak
    Contributor

    @N3XT14 The PR was linking a failed test job, think https://github.com/matplotlib/matplotlib/actions/runs/4679682790 for example, github just removes old actions understandably.

    EDIT: Heh, things ballooned quite nicely, a nifty half a gig for every failed PR :D

  9. tacaswell commented on Apr 14, 2023

    @tacaswell
    MemberAuthor

    @N3XT14 If that PR still looks good, then the task is to rebase in on current main, fix anything that is failing, verify it is doing what we want, and then shepherd it through review process.

  10. lukas-mar commented on Oct 7, 2023

    @lukas-mar

    Hi, I would love to start working on this issue, can I get assigned to it? thanks.

  11. rcomer commented on Oct 7, 2023

    @rcomer
    Member

    @lukas-mar you are welcome to submit a pull request for any issue, but we do not assign them. Please see our contributors’ guide:
    https://matplotlib.org/devdocs/devel/index.html

  12. added this to the v3.10.0 milestone on Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    🌱 Good first issueOpen a pull request against these issues if there are no active ones!

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions