Repository navigation
[ENH]: do_3d_projection could restore original verts order after draw() finishes #23155
Description
Problem
do_3d_projection() reorders vertices of various 3D collection artists in z-depth. Once the drawing is done, it would be useful to restore back the original order, so that e.g. interactive tools (mplcursors) reporting the index of a picked collection member get the original index as set by the user (anntzer/mplcursors#49). This should be reasonably cheap to do as we can probably just stash the original arrays somewhere and restore them as attributes at the end.
In practice, this probably means adding another API like doing_3d_projection() which returns a contextmanager (or letting do_3d_projection() possibly return a contextmanager and doing a typecheck on that) and replacing the calls to do_3d_projection() to stack.enter_context(artist.doing_3d_projection()) where stack = ExitStack() is defined at the top of Axes3D.draw().
Proposed solution
No response
Activity
tacaswell commentedon May 27, 2022
Tagging this as a good first issue because I think this can be done without adding any public API, but medium because you should be conversant with writing context managers and will need to read and understand the 3D artist code.
evanandresen commentedon Sep 17, 2022
Could I work on this issue? This is my first time looking into matplotlib src and I would like to help out.
tacaswell commentedon Sep 18, 2022
Yes, unless there is an active PR the issue is fair game!
As noted above, you will need to be familiar with context managers and read/understand the 3D code which a bit complex. If you start on this and have any questions about the existing code please ask!
QuLogic commentedon Sep 20, 2022
I did this for some cases in #18932; I should probably return to the rest.
hukaidong commentedon Dec 5, 2022
PR #24491 would be enough to close this issue
tacaswell commentedon Dec 5, 2022
Closed by #24491
tacaswell commentedon Dec 5, 2022
Thank you for the triage work @hukaidong !