You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[MNT]: macos-latest memory leak over threshold #22959
@oscargus I think my original solution (#22961) didn't cover the whole problem. The original examples of this test failing was specifically with macosx and the threshold was less than 1000000 off.
Looking at this in detail, I was wrong about how the tests are run. They are in their own process so the inter-test interaction should not be a problem. It seems there is just a lot of variation, but we do not know why.
I think that in addition to the OSX backend on osx, we also need to increase the threshold when running with tkagg on osx. I'm going to open a PR with that stage and also write up an issue starting the discussion about how we may need to find a more stable way to benchmark these memory issues.
Activity
andrew-fennell commentedon May 2, 2022
Threshold can be raised by 1000000 (double 457856) to account for fluctuation.
andrew-fennell commentedon May 5, 2022
@oscargus I think my original solution (#22961) didn't cover the whole problem. The original examples of this test failing was specifically with macosx and the threshold was less than 1000000 off.
The test that is failing:
matplotlib/lib/matplotlib/tests/test_backends_interactive.py
Lines 543 to 556 in 2e70254
Here is an example of this tests still failing: https://github.com/matplotlib/matplotlib/runs/6246645151?check_suite_focus=true
Should I make this adjustment?
@pytest.mark.parametrize("time_mem", [(0.0, 2_000_000), (0.1, 35_000_000)])andrew-fennell commentedon May 5, 2022
Talked about in dev call: https://hackmd.io/jd_7FjxNQ4y7XgNknvmvGQ#memory-issue
tacaswell commentedon May 6, 2022
Looking at this in detail, I was wrong about how the tests are run. They are in their own process so the inter-test interaction should not be a problem. It seems there is just a lot of variation, but we do not know why.
I think that in addition to the OSX backend on osx, we also need to increase the threshold when running with tkagg on osx. I'm going to open a PR with that stage and also write up an issue starting the discussion about how we may need to find a more stable way to benchmark these memory issues.
CI: bump test limit from tkagg on osx
CI: bump test limit from tkagg on osx
CI: bump test limit from tkagg on osx