Skip to content

Add darken and lighten to colors #2159

Closed

Description

@dvreed77

I was looking for something to contribute and have implemented some simple code to take a color and darken or lighten it. I found having this very useful in many instances and I think others would to. Do you agree and/or have any pointers for contributing since this is my first time.

Activity

  1. mdboom commented on Jul 1, 2013

    @mdboom
    Member

    We're glad to have you! Maybe just file a pull request showing what you have in mind, and we can start the discussion from there, with the understanding that pull requests (even from those of us that have been here a while) may change many times before they're ready.

  2. pelson commented on Jul 16, 2013

    @pelson
    Member

    This sounds pretty cool. Did you manage to submit any code @dvreed77?

  3. dvreed77 commented on Jul 16, 2013

    @dvreed77
    Author

    I hope to soon, life got in the way a little bit and I want to make sure I do this right and not rush it.

    On Jul 16, 2013, at 4:22, Phil Elson notifications@github.com wrote:

    This sounds pretty cool. Did you manage to submit any code @dvreed77?

    —
    Reply to this email directly or view it on GitHub.

  4. tacaswell commented on Jan 17, 2014

    @tacaswell
    Member

    @dvreed77 Did you ever get a chance to work on this?

  5. dvreed77 commented on Jan 17, 2014

    @dvreed77
    Author

    I'm sorry I didn't. I'll see if I can squeeze it in sometime soon!

    On Fri, Jan 17, 2014 at 12:59 AM, Thomas A Caswell <notifications@github.com

    wrote:

    @dvreed77 https://github.com/dvreed77 Did you ever get a chance to work
    on this?

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/2159#issuecomment-32582069
    .

  6. dvreed77 commented on Jan 19, 2014

    @dvreed77
    Author

    I just submitted a code review to the devel mailing list on this. Thanks
    for kicking me in the pants a bit ;)

    On Fri, Jan 17, 2014 at 12:59 AM, Thomas A Caswell <notifications@github.com

    wrote:

    @dvreed77 https://github.com/dvreed77 Did you ever get a chance to work
    on this?

    —
    Reply to this email directly or view it on GitHubhttps://github.com//issues/2159#issuecomment-32582069
    .

  7. tacaswell commented on Mar 8, 2014

    @tacaswell
    Member

    Closing in favor of the open PR #2745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions