Skip to content

MAINT: CircleCI build merged PRs #20658

Closed

Description

@larsoner

Describe the issue

CircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with upstream/master. This forces people to rebase to deal with issues that crop up, for example in #20585 (comment), and also decreases uniformity across CIs.

Proposed fix

For a while (years?) in MNE now we have manually merged pull requests after the checkout step. I'm happy to port our code if people agree it would be useful. The only time it breaks or dies is when there are merge conflicts (i.e., the code can't be successfully merged), which arguably is fine behavior because people should merge/rebase at that point anyway.

EDIT: Also need these lines

Activity

  1. QuLogic commented on Jul 16, 2021

    @QuLogic
    Member

    Sure, feel free to PR it here. I've also been meaning to cop the better name for the CircleCI artifact check job that you have.

  2. added this to the v3.5.0 milestone on Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions