Skip to content

PyPy wheels are pinned to v3.3, so pypy-based wheels for latest versions are not available #20637

Closed

Description

@mattip

Bug report

Bug summary

In the cibuildwheel configuration there is a condition to pin PyPy wheels on 3.3

if: >
runner.os != 'Windows' && (
startsWith(github.ref, 'refs/heads/v3.3') ||
startsWith(github.ref, 'refs/tags/v3.3') )

Is that on purpose? I would be nice to have PyPy wheels for the latest versions

Activity

  1. QuLogic commented on Jul 12, 2021

    @QuLogic
    Member

    PyPy did not support 3.7, which was our minimum in 3.4. The initial releases that did were not in cibuildwheel and also buggy, but new releases may have fixed it.

  2. QuLogic commented on Jul 12, 2021

    @QuLogic
    Member
  3. QuLogic commented on Jul 12, 2021

    @QuLogic
    Member

    OK, guess there still hasn't been a release adding Py_DTSF_ADD_DOT_0; new test build: https://github.com/QuLogic/matplotlib/actions/runs/1024666763

  4. mattip commented on Jul 13, 2021

    @mattip
    ContributorAuthor

    It was added in v7.3.4, released in April. I wonder why cibuildwheel is not using the latest v7.3.5 released in May, which fixes some problems with win64.

  5. mattip commented on Jul 13, 2021

    @mattip
    ContributorAuthor

    The latest build is missing METH_FASTCALL, which was also added in v7.3.4

  6. QuLogic commented on Jul 13, 2021

    @QuLogic
    Member

    I don't know why, but yea, waiting for cibuildwheel to update is what I remember now.

    We can actually build 3.4, except for aarch64, looks like: https://github.com/QuLogic/matplotlib/runs/3052871926

  7. QuLogic commented on Jul 19, 2021

    @QuLogic
    Member
  8. mattip commented on Jul 19, 2021

    @mattip
    ContributorAuthor

    Cool!

  9. self-assigned this
    on Aug 14, 2021
  10. tacaswell commented on Aug 14, 2021

    @tacaswell
    Member

    This appears to be broken on the default branch after I merged 3.4.x up.

    gcc -pthread -DNDEBUG -O2 -fPIC -DPY_ARRAY_UNIQUE_SYMBOL=MPL_matplotlib_backends__tkagg_ARRAY_API -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -D__STDC_FORMAT_MACROS=1 -Iextern/agg24-svn/include -Isrc -I/opt/pypy/pypy3.7-7.3.3/site-packages/numpy/core/include -I/opt/pypy/pypy3.7-7.3.3/include -c src/_tkagg.cpp -o build/temp.linux-x86_64-3.7/matplotlib.backends._tkagg/src/_tkagg.o -fvisibility=hidden -flto
    1110
        src/_tkagg.cpp:208:7: error: ‘METH_FASTCALL’ was not declared in this scope
    1111
               METH_FASTCALL },
    1112
               ^~~~~~~~~~~~~
    1113
        src/_tkagg.cpp:208:7: note: suggested alternative: ‘METH_STATIC’
    1114
               METH_FASTCALL },
    1115
               ^~~~~~~~~~~~~
    1116
               METH_STATIC
    1117
        error: command 'gcc' failed with exit status 1
    1118
        ----------------------------------------
    
  11. tacaswell commented on Aug 14, 2021

    @tacaswell
    Member

    The METH_FASTCALL line came in via 741ee02 / #19167

  12. tacaswell commented on Aug 14, 2021

    @tacaswell
    Member

    Sigh, I should read the top of the thread before posting, I see @mattip predicted this problem in #20637 (comment)

  13. QuLogic commented on Aug 16, 2021

    @QuLogic
    Member

    Ah yes, that's why I only sent the original CI change to v3.4.x.

  14. added this to the v3.5.0 milestone on Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions