You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
BUG: Lost functionality of interactive selector update #20618
This now emits a deprecation warning from #20113, but it doesn't indicate how code should be migrated. I looked at this and #20558 and hoped / thought maybe I could find some selector.set_* or selector.handle_props or something to modify but I don't see anything. How should we update our code? (And it might be worth improving the deprecation warning to give some hints to anyone else who hits this issue.) Maybe with something like this?
selector.artists[0].set_color(color)
the artists[0] is the selector.rect. But this just seems like a hack workaround, and if there are properties held internally it will not "stick" so I'm guessing it's not the right idea...
I would lean toward having something along the line of selector.set_props and selector.set_handle_props for all selectors. Should it be done as part as part of #20585, where there is a discussion about renaming corresponding parameters?
Well, since that's merged, it'll have to be a new PR, but yes, I expect it should be some .set_* methods, and not accessing the child artists directly.
Activity
jklymak commentedon Jul 9, 2021
@ericpre @timhoffm any suggestions here? Thanks!
ericpre commentedon Jul 10, 2021
I would lean toward having something along the line of
selector.set_propsandselector.set_handle_propsfor all selectors. Should it be done as part as part of #20585, where there is a discussion about renaming corresponding parameters?QuLogic commentedon Jul 20, 2021
Well, since that's merged, it'll have to be a new PR, but yes, I expect it should be some
.set_*methods, and not accessing the child artists directly.