Skip to content

YearLocator dropped replaced attribute #20313

Closed as not planned
Closed as not planned

Description

@jklymak

Is it worth putting in the a property what warns on get/set? On one hand, most likely no one is using this, on the other hand it is not much work to make sure we do not needlessly break anyone who is trying to access this.

Originally posted by @tacaswell in #19348 (comment)

In #19348 the YearLocator.replaced attribute was not documented, nor was it tested, so it was dropped with an API note. @tacaswell suggested than maybe instead we should have a setter/getter that does the right thing?

Activity

  1. added this to the v3.5.0 milestone on May 26, 2021
  2. changed the title [-]YearLocator dropped replace attribute[/-] [+]YearLocator dropped replaced attribute[/+] on May 26, 2021
  3. timhoffm commented on May 27, 2021

    @timhoffm
    Member

    I'm ok with not going through a deprecation here (that's why I merged #19348). While I'm usually very catious with breaking changes, I dare to be pragmatic here and assume that this is too obscure that anybody will use it. But if somebody wants to do the deprecation dance, I'm not holding you up.

  4. modified the milestones: v3.5.0, v3.6.0 on Sep 25, 2021
  5. modified the milestones: v3.6.0, v3.7.0 on Aug 24, 2022
  6. QuLogic commented on Jan 24, 2023

    @QuLogic
    Member

    The removal was in 3.5, and our two-release deprecation cycle means that it would be removed now in 3.7, if one was put in at the time. It is probably unlikely that anyone has had an issue with this removal, as I don't recall any bug reports about it.

  7. removed this from the v3.7.0 milestone on Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions