You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The library (and includes) (lib)qull have been deprecated in favor of the new reentrant version which is (lib)qhull_r
On my Gentoo system I (only) have
/usr/lib64/libqhull_r.so
and
/usr/include/libqhull_r/*
Please fix matplotlib to work with this recent qhull
Either version may be used. New code should use reentrant Qhull.
which seems a bit at-odds with the default behavior to not build the non-reentrant versions by default. It looks like you can ask for the non-reentrant version of the libraries to be built (for reference it looks like Arch builds both versions) so I think that this should be fixed on the gentoo packaging side for now.
That said, we should still update the version of qhull we vendor and support (we currently are on 2015.2).
labeled as medium difficulty because it involves c code, but good first issue because the changes should be well isolated.
attn @ianthomas23 . Will defer to Ian's judgement on the right path here.
Yes, we need to use the reentrant version of qhull. I submitted a PR to do this, and update to qhull 2019.1, about 10 months ago (#16571).
It stalled following discussion of whether we should continue to ship qhull code ourselves (my PR) or download it at build time (@anntzer's #16720). A decision is needed on this before we can progress.
I have removed the "Good first issue" label as qhull upgrades invariably break some of our image tests, and dealing with these needs some judgement/experience.
If we opt for downloading at build time (#16720) we'll need another PR to switch to downloading the latest qhull rather than 2015, and to change qhull_wrap.c to use the reentrant API. The latter can mostly be cherry-picked from #16571.
Activity
tacaswell commentedon Jan 5, 2021
We appear to only use qhull from c and https://github.com/qhull/qhull/blob/master/src/libqhull/DEPRECATED.txt says
and http://www.qhull.org/html/qh-code.htm#library says
which seems a bit at-odds with the default behavior to not build the non-reentrant versions by default. It looks like you can ask for the non-reentrant version of the libraries to be built (for reference it looks like Arch builds both versions) so I think that this should be fixed on the gentoo packaging side for now.
That said, we should still update the version of qhull we vendor and support (we currently are on 2015.2).
labeled as medium difficulty because it involves c code, but good first issue because the changes should be well isolated.
attn @ianthomas23 . Will defer to Ian's judgement on the right path here.
anntzer commentedon Jan 5, 2021
@tacaswell see #16720, I guess.
ianthomas23 commentedon Jan 5, 2021
Yes, we need to use the reentrant version of qhull. I submitted a PR to do this, and update to qhull 2019.1, about 10 months ago (#16571).
It stalled following discussion of whether we should continue to ship qhull code ourselves (my PR) or download it at build time (@anntzer's #16720). A decision is needed on this before we can progress.
ianthomas23 commentedon Jan 5, 2021
I have removed the "Good first issue" label as qhull upgrades invariably break some of our image tests, and dealing with these needs some judgement/experience.
tacaswell commentedon Jan 5, 2021
Ah, great, glad we have options of how to fix this already open :)
ianthomas23 commentedon Jan 5, 2021
If we opt for downloading at build time (#16720) we'll need another PR to switch to downloading the latest qhull rather than 2015, and to change
qhull_wrap.cto use the reentrant API. The latter can mostly be cherry-picked from #16571.ianthomas23 commentedon Jan 15, 2021
Closed by #16720.