Skip to content

nbagg: Closing a figure from the notebook does not close the python figure #18447

Closed

Description

@sbitzer

I'm reporting a digression from previous behaviour of the nbagg backend in Jupyter notebooks. Until matplotlib 3.2.2, when I refreshed an interactive figure in a notebook cell by re-executing the cell, the existing figure would be closed and a new one created using the old figure number (when the cell also created the original figure). In matplotlib 3.3.1 the old figure is replaced by the new figure (with a new figure number) in the notebook output, but the old figure still exists in the kernel.

I guess this is related to "NbAgg and WebAgg no longer use jQuery & jQuery UI" from the release notes of matplotlib 3.3.0. Also, ipympl has the same issue: matplotlib/ipympl#4.

This can be tested in a notebook with:

%matplotlib notebook
import matplotlib.pyplot as plt
fig = plt.figure()
plt.get_fignums()

I saw this behaviour in recent versions of Firefox and Google Chrome.

I have manually applied 2c9a85b in case this would reintroduce the old behaviour (which I prefer), but it didn't.

Activity

  1. jklymak commented on Sep 10, 2020

    @jklymak
    Member

    Is this related to #17086 #17053? @QuLogic ? This seems a pretty major regression - I certainly have notebooks with dozens of figures that I will then execute dozens of times.

  2. added this to the v3.3.2 milestone on Sep 10, 2020
  3. QuLogic commented on Sep 11, 2020

    @QuLogic
    Member

    I think this is because jQuery has a wrapped remove event, but it doesn't actually exist in HTML/JS, so this change is never triggered to close the figure.

  4. added a commit that references this issue on Sep 11, 2020
    840035c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions