You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Regression in get_navigate_mode() return value #18150
This is a breaking API change. Before the returned values were 'PAN', 'ZOOM', or None (as is still documented). Now, these values are 'pan/zoom', 'zoom rect' and ''. Ping @anntzer I don't see if these values translate 1:1. Why is _Mode.PAN = 'pan/zoom'?
That's just because I confused ax.{get,set}_navigate_mode() ('PAN'/'ZOOM'/None) and toolbar.mode ('pan/zoom'/'zoom rect'/''). I think this just needs something like
diff --git i/lib/matplotlib/backend_bases.py w/lib/matplotlib/backend_bases.py
index 2dd41cdf5..f42a7664f 100644
--- i/lib/matplotlib/backend_bases.py+++ w/lib/matplotlib/backend_bases.py@@ -2784,6 +2784,10 @@ class _Mode(str, Enum):
def __str__(self):
return self.value
+ @property+ def _navigate_mode(self):+ return {"NONE": None, "PAN": "PAN", "ZOOM": "ZOOM"}[self.name]+
class NavigationToolbar2:
"""
@@ -3047,7 +3051,7 @@ class NavigationToolbar2:
self.mode = _Mode.PAN
self.canvas.widgetlock(self)
for a in self.canvas.figure.get_axes():
- a.set_navigate_mode(self.mode)+ a.set_navigate_mode(self.mode._navigate_mode)
self.set_message(self.mode)
def press_pan(self, event):
@@ -3117,7 +3121,7 @@ class NavigationToolbar2:
self.mode = _Mode.ZOOM
self.canvas.widgetlock(self)
for a in self.canvas.figure.get_axes():
- a.set_navigate_mode(self.mode)+ a.set_navigate_mode(self.mode._navigate_mode)
self.set_message(self.mode)
def press_zoom(self, event):
Activity
anntzer commentedon Aug 2, 2020
That's just because I confused
ax.{get,set}_navigate_mode()('PAN'/'ZOOM'/None) andtoolbar.mode('pan/zoom'/'zoom rect'/''). I think this just needs something like?
QuLogic commentedon Aug 4, 2020
Went with a slightly different implementation. Too bad it isn't
'NONE'instead ofNone, though.Fix the return value of Axes.get_navigate_mode.