Repository navigation
Quadmesh.set_array should validate dimensions #17508
Description
#16908 has added the ability to call Quadmesh.set_array with a 2-D argument.
When a Quadmesh is instantiated, its grid of vertices is fixed. It would be good to
have set_array validate its argument so that regardless of whether it has already
been flattened or whether it is a 2-D array such as one would supply to pcolormesh,
its dimensions are consistent with the dimensions of the vertex grid.
Activity
tacaswell commentedon Jul 7, 2020
This is a good first issue because it does not require changes to the public API, but medium difficulty because it does involve adding a bit of state to the Artist and working through the history / variety of data shapes that can be passed in to determine what we need to check against.
done-my-way commentedon Jul 8, 2020
@tacaswell
Hello, I'd like to work on the issue. It's my first contribution, so I'd like to ask, what is the workflow? fork -> create new branch (from which one) -> make changes -> open a PR 😅
timhoffm commentedon Jul 8, 2020
These may help:
https://matplotlib.org/devdocs/devel/contributing.html#contributing-code
https://matplotlib.org/devdocs/devel/coding_guide.html#pull-request-guidelines
petor-traffs commentedon Dec 2, 2020
@tacaswell Hello!! I'm looking to make my first contribution in an Open Source project! I was wondering if this issue is still available. If so, is there anything I could start with? Thank you in advance!
dopplershift commentedon Dec 4, 2020
The issue is still open and there aren't any linked Pull Requests, so have at it!
jeffreypaul15 commentedon May 8, 2021
From what I understand,
set_arrayneeds to validate it's arguments if it has been flattened or is still a 2D array. Am I missing out anything else?