dict unpacking broken for .plot in 3.2 #17502

Activity

1. story645

   changed the title [-]dict support broken in 3.2[/-] [+]dict support for categoricals broken in 3.2[/+] on May 24, 2020
2. story645

   changed the title [-]dict support for categoricals broken in 3.2[/-] [+]dict support for units broken in 3.2[/+] on May 24, 2020
3. story645

   added

   topic: units and array ducktypes

   on May 24, 2020
4. story645

   changed the title [-]dict support for units broken in 3.2[/-] [+]dict unpacking for units broken in 3.2[/+] on May 24, 2020
5. story645

   changed the title [-]dict unpacking for units broken in 3.2[/-] [+]preprocess_data broken for units in 3.2[/+] on May 24, 2020
6. story645

   changed the title [-]preprocess_data broken for units in 3.2[/-] [+]dict unpacking broken for units in 3.2[/+] on May 24, 2020
7. jklymak commented on May 25, 2020

   

   jklymak

   on May 25, 2020

   Last edited by jklymak

   Member

   More actions

   Bisects to 2445465, #10928. I guess this needed user-facing tests?
8. story645 commented on May 25, 2020

   

   story645

   on May 25, 2020

   MemberAuthor

   More actions

   @jklymak thanks for finding that, was unsure where to start on the debugging. And yeah, though not sure where to put them - there's preprocess data tests but they mock out the plot calls. But I guess can throw an integration test in there...

   Also how do you bisect?
9. jklymak commented on May 25, 2020

   

   jklymak

   on May 25, 2020

   Member

   More actions

   Git bisect. Very helpful tool if you know something used to work!

   👍React with 👍1Reacted by hannah
10. story645 commented on May 25, 2020

    

    story645

    on May 25, 2020

    Last edited by story645

    MemberAuthor

    More actions

    thanks! and figured I can shove the tests into units since that's where the issue happens 😅
    never mind, not a units bug 🤦
11. story645

    changed the title [-]dict unpacking broken for units in 3.2[/-] [+]dict unpacking broken for `.plot` in 3.2[/+] on May 25, 2020
12. story645

    removed

    topic: units and array ducktypes

    on May 25, 2020
13. story645

    added 2 commits that reference this issue on May 25, 2020

    closes matplotlib#17502 by adding check to plot

    This issue will close once commit 473d06e is merged into the 'main' branch.

    473d06e

    closes matplotlib#17502 by adding check to plot

    This issue will close once commit 2e20e67 is merged into the 'main' branch.

    2e20e67
14. story645

    linked a pull request that will close this issueFix dicts unpacking for `.plot` #17506on May 25, 2020
15. tacaswell

    closed this as completedin #17506on May 25, 2020
16. QuLogic

    added this to the v3.3.0 milestone on May 25, 2020