Skip to content

LGTM no longer checks C code #17063

Closed
Closed

Description

@QuLogic

A long time ago, our LGTM Check used to work with the C/C++ code, but it stopped doing so. Currently, this is because it runs setup.py using Python 2 and we have Python 3.6 syntax in it. We should be able to configure it to not use Python 2 easily.

However, prior to that, it failed because it could not download jQuery. I am working towards removing that requirement entirely, but this is something we should keep in mind if more things are downloaded (e.g., #16720).

And before anyone asks about the utility of LGTM, yes it's not blocking and full of many false positives, but I did go through it once and find several real bugs (e.g., #16802.) And since C/C++ is probably the language with least proficiency on the team, more eyes on it would be better.

Activity

  1. github-actions commented on Jul 21, 2023

    @github-actions

    This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

  2. QuLogic commented on Jul 21, 2023

    @QuLogic
    MemberAuthor

    LGTM is gone, but #23812 enabled C/C++ checking with CodeQL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions