You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
and in duplicating comments, I think the caching as the sha is ok (as users should put the files in the tree where they should be rather than rely on putting things in the right place in the cache) and the issue with freetype has PRs / commits to fix it.
But for the case of FreeType that doesn't really work anymore (I think?)? Previously you could just have the tarball in the cache and we wouldn't try to download it, now you need to have the tarball renamed to the sha for that.
Activity
MNT: fix logic error where we never try the second freetype URL
tacaswell commentedon Feb 17, 2019
milestoned an 3.0.3 as 4de6dfb is on the PR into 2.2.x and the backport bot only needs to pull this back to 3.0.x.
tacaswell commentedon Feb 17, 2019
and in duplicating comments, I think the caching as the sha is ok (as users should put the files in the tree where they should be rather than rely on putting things in the right place in the cache) and the issue with freetype has PRs / commits to fix it.
anntzer commentedon Feb 17, 2019
But for the case of FreeType that doesn't really work anymore (I think?)? Previously you could just have the tarball in the cache and we wouldn't try to download it, now you need to have the tarball renamed to the sha for that.
anntzer commentedon Feb 17, 2019
The FreeType issue just above remains valid (well, at least unless @tacaswell explicitly dismisses it, which is fine with me too).
tacaswell commentedon Feb 17, 2019
Ah, I miss understood some of the bail logic, another PR coming.
BLD: only try to get freetype src if src does not exist