Skip to content

Issues with jquery download caching #13450

Description

@anntzer

Looks like I missed two points when reviewing @tacaswell's parts of #11246: #11246 (review) and #11246 (review).

Activity

  1. added this to the v2.2.4 milestone on Feb 16, 2019
  2. modified the milestones: v2.2.4, v3.0.3 on Feb 17, 2019
  3. added a commit that references this issue on Feb 17, 2019
    4abf7db
  4. tacaswell commented on Feb 17, 2019

    @tacaswell
    Member

    milestoned an 3.0.3 as 4de6dfb is on the PR into 2.2.x and the backport bot only needs to pull this back to 3.0.x.

  5. tacaswell commented on Feb 17, 2019

    @tacaswell
    Member

    and in duplicating comments, I think the caching as the sha is ok (as users should put the files in the tree where they should be rather than rely on putting things in the right place in the cache) and the issue with freetype has PRs / commits to fix it.

  6. anntzer commented on Feb 17, 2019

    @anntzer
    ContributorAuthor

    But for the case of FreeType that doesn't really work anymore (I think?)? Previously you could just have the tarball in the cache and we wouldn't try to download it, now you need to have the tarball renamed to the sha for that.

  7. anntzer commented on Feb 17, 2019

    @anntzer
    ContributorAuthor

    The FreeType issue just above remains valid (well, at least unless @tacaswell explicitly dismisses it, which is fine with me too).

  8. tacaswell commented on Feb 17, 2019

    @tacaswell
    Member

    Ah, I miss understood some of the bail logic, another PR coming.

  9. added a commit that references this issue on Feb 17, 2019
    2ff0f71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions