You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
plt.scatter crashes because overwrites the colors to an empty list #12664
xs, ys, zs, s, c=cbook.delete_masked_points(xs, ys, zs, s, c)
Code for reproduction
We hit this bug in mne-tools/mne-python#5676, but here is a MWE. Most probably this is a duplicated of #12641. In which case, this can be used as a test.
(As in matplotlib 2.2.2) we would expect an empty plot with no error
In [25]: matplotlib.__version__
Out[25]: '2.2.2'
In [26]: %paste
import matplotlib.pyplot as plt
import numpy as np
n_points = 4
xs = ys = zs = np.full(n_points, np.nan)
colors = list(np.full(2, 'k'))
plt.scatter(xs, ys, zs, c=colors)
plt.show()
## -- End pasted text --
In [27]:
Actual outcome
It breaks because cannot iterate over c
In [9]: matplotlib.__version__
Out[9]: '3.0.1'
In [10]: %paste
import matplotlib.pyplot as plt
import numpy as np
n_points = 4
xs = ys = zs = np.full(n_points, np.nan)
colors = list(np.full(2, 'k'))
plt.scatter(xs, ys, zs, c=colors)
plt.show()
## -- End pasted text --
Traceback (most recent call last):
File "<ipython-input-10-f59e87d45c38>", line 7, in<module>
plt.scatter(xs, ys, zs, c=colors)
File "/home/sik/miniconda3/envs/mne/lib/python3.6/site-packages/matplotlib/pyplot.py", line 2864, in scatter
is not None else {}), **kwargs)
File "/home/sik/miniconda3/envs/mne/lib/python3.6/site-packages/matplotlib/__init__.py", line 1805, in inner
return func(ax, *args, **kwargs)
File "/home/sik/miniconda3/envs/mne/lib/python3.6/site-packages/matplotlib/axes/_axes.py", line 4234, in scatter
.format(nc=n_elem, xs=x.size, ys=y.size)
ValueError: 'c' argument has 2 elements, which is not acceptable for use with 'x' with size 4, 'y' with size 4.
x, y : array_like, shape (n, ) c : color, sequence, or sequence of color, optional, default: 'b'
The marker color. Possible values:
[...]
A sequence of color specifications of length n.
So I think it was never intended that x and c are of different length. (And that is independent if them containing nans, or not.) I think the fact that it worked in some previous version was just an implementation detail. Or is there an argument that the colors should be cycled through?
@ImportanceOfBeingErnest Sorry I mess up the snipped, I think that the error is related to #11373. Feel free to close if the issue is irrelevant. Sorry for the noise.
Activity
ImportanceOfBeingErnest commentedon Oct 29, 2018
Bisects to #11383; also relevant #11373.
The scatter documentation is rather clear
So I think it was never intended that
xandcare of different length. (And that is independent if them containing nans, or not.) I think the fact that it worked in some previous version was just an implementation detail. Or is there an argument that the colors should be cycled through?anntzer commentedon Oct 29, 2018
See also #12021, I guess...
massich commentedon Oct 29, 2018
I mess up the MWE. It was supposed to be this one:
In that case, they are all the same and the tests passh. Which means that my MWE was wrong. I'll repoen if needed.
massich commentedon Oct 29, 2018
Sorry it was needing to be 3D.
And this is the error:
IndexError: index 0 is out of bounds for axis 0 with size 0massich commentedon Oct 29, 2018
@ImportanceOfBeingErnest Sorry I mess up the snipped, I think that the error is related to #11373. Feel free to close if the issue is irrelevant. Sorry for the noise.
ImportanceOfBeingErnest commentedon Oct 29, 2018
The new 3D code with equal length lists bisects to #12431, which is the same PR that introduced the problem in #12641. So I guess we can close this.
massich commentedon Oct 29, 2018
Thx.