You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test_axes.py::test_csd_freqs failing with numpy 1.15.0 on macOS #11766
Personally I think we should deprecate csd, psd and friends... We shouldn't have our own version of the computation of spectral statistics, and the plots are trivial after the the spectra are calculated.
I completely agree! I tried to work out a good way to do all the deprecation, but it would require a major breaking API change, so requires quite a bit of thought at work. I'm +1 on getting rid of the rest of mlab, but think keeping ax.csd etc. is okay as long as they use scipy or numpy to do the underlying computations.
I'd still deprecate axes.psd, axes.csd, axes.magnitude_spectrum, axes.angle_spectrum, axes.phase_spectrum, axes.cohere, and axes.specgram. I think a plan discussed at some point was to move them into a toolbox to give folks a straight-to-plot method of getting these statistical plots. I think that'd make deprecation pretty straight forward as all the mlab and axes methods could just be moved to there and called from the deprecated methods. Then the maintainer of mpl_spectral could decide how to eventually get rid of the stuff brought over from mlab.
Probably the right way to do this is to talk to the maintainers of the scipy spectral functions and develop a version of these that uses scipy and put them in their own package.
Activity
matthew-brett commentedon Jul 24, 2018
We recently changed to using OpenBLAS for the Mac wheels - maybe that's the explanation?
dstansby commentedon Jul 24, 2018
Here's what I get locally:

And here's the expected image:

There's no noticeable change in the diff, so as @jklymak suggested I think it's safe just to add a small tolerance to this test.
jklymak commentedon Jul 24, 2018
Personally I think we should deprecate
csd,psdand friends... We shouldn't have our own version of the computation of spectral statistics, and the plots are trivial after the the spectra are calculated.dstansby commentedon Jul 24, 2018
I completely agree! I tried to work out a good way to do all the deprecation, but it would require a major breaking API change, so requires quite a bit of thought at work. I'm +1 on getting rid of the rest of
mlab, but think keepingax.csdetc. is okay as long as they usescipyornumpyto do the underlying computations.jklymak commentedon Jul 24, 2018
I'd still deprecate
axes.psd,axes.csd,axes.magnitude_spectrum,axes.angle_spectrum,axes.phase_spectrum,axes.cohere, andaxes.specgram. I think a plan discussed at some point was to move them into a toolbox to give folks a straight-to-plot method of getting these statistical plots. I think that'd make deprecation pretty straight forward as all the mlab and axes methods could just be moved to there and called from the deprecated methods. Then the maintainer ofmpl_spectralcould decide how to eventually get rid of the stuff brought over frommlab.End-users would call
tacaswell commentedon Jul 25, 2018
Probably the right way to do this is to talk to the maintainers of the scipy spectral functions and develop a version of these that uses scipy and put them in their own package.