Skip to content

FigureManagerQT used in new_figure_manager of Qt4Agg backend #1151

Closed

Description

@pmeier82-zz

There seems to be a FigureManagerQTAgg defined in backend_qt4agg.py, just wondering why its not used.

ref

Activity

  1. pelson commented on Aug 27, 2012

    @pelson
    Member

    Sensible question. Seems like it is a typo and is redundant. An extension to this would be to question the purpose of NavigationToolbar2QTAgg.

  2. tacaswell commented on Nov 29, 2013

    @tacaswell
    Member

    I actually think this is a bug that they are not used in new_figure_manager_given_figure in backend_qt4agg.

  3. efiring commented on Nov 30, 2013

    @efiring
    Member

    No, I think that both NavigationToolbar2QTAgg and FigureManagerQTAgg should be deleted from backend_qt4agg.py. They are functionally identical to their non-Agg counterparts. Neither the toolbar nor the Manager needs to know how the canvas is being rendered (i.e., by Agg).

  4. added a commit that references this issue on Nov 30, 2013
    0a15e57
  5. efiring commented on Nov 30, 2013

    @efiring
    Member

    PR #2629 seems to work; give it a try.

  6. tacaswell commented on Nov 30, 2013

    @tacaswell
    Member

    I had assumed it was overriding something, but that seems to not be true (nor does it seem to ever be called). I will leave other comments on the PR

  7. added a commit that references this issue on Nov 30, 2013
    b1ee8b2
  8. added a commit that references this issue on Nov 30, 2013
    f226149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions