You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FigureManagerQT used in new_figure_manager of Qt4Agg backend #1151
No, I think that both NavigationToolbar2QTAgg and FigureManagerQTAgg should be deleted from backend_qt4agg.py. They are functionally identical to their non-Agg counterparts. Neither the toolbar nor the Manager needs to know how the canvas is being rendered (i.e., by Agg).
Activity
pelson commentedon Aug 27, 2012
Sensible question. Seems like it is a typo and is redundant. An extension to this would be to question the purpose of
NavigationToolbar2QTAgg.tacaswell commentedon Nov 29, 2013
I actually think this is a bug that they are not used in
new_figure_manager_given_figureinbackend_qt4agg.efiring commentedon Nov 30, 2013
No, I think that both NavigationToolbar2QTAgg and FigureManagerQTAgg should be deleted from backend_qt4agg.py. They are functionally identical to their non-Agg counterparts. Neither the toolbar nor the Manager needs to know how the canvas is being rendered (i.e., by Agg).
backend_qt4agg: remove redundant classes. Closes matplotlib#1151.
efiring commentedon Nov 30, 2013
PR #2629 seems to work; give it a try.
tacaswell commentedon Nov 30, 2013
I had assumed it was overriding something, but that seems to not be true (nor does it seem to ever be called). I will leave other comments on the PR
backend_qt4agg and qt4: remove redundant classes, unused method. Closes
Merge pull request #2629 from efiring/qt4agg_remove_unneeded