You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would it make sense to not vendor jquery in the repo, but
change setup.py so that it fetches jquery at build time, normally online but configurably (via e.g. environment variable) from a local path (to satisfy distro packager constraints).
the sdist would not contain jquery but follow the same idea
the wheels would contain jquery.
Right now jquery weights 1.3Mb; compare this with the baseline test images that weight ~50Kb each and that we are painstakingly trying to avoid adding to the repo.
On Tue, May 8, 2018 at 8:36 PM, Antony Lee ***@***.***> wrote:
Would it make sense to not vendor jquery in the repo, but
1. change setup.py so that it fetches jquery at build time, normally
online but configurably (via e.g. environment variable) from a local path
(to satisfy distro packager constraints).
2. the sdist would not contain jquery but follow the same idea
3. the wheels would contain jquery.
Right now jquery weights 1.3Mb; compare this with the baseline test images
that weight ~50Kb each and that we are painstakingly trying to avoid adding
to the repo.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#11199 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARy-HdbRhMgZWsaSKyfGvuV8MZ9iBSqks5twjn7gaJpZM4T2uCC>
.
Actually now that I think of it, for debian & friends the even simpler solution is to also bundle jquery in the sdists (they're building from a sdist, not from a checkout). See comment in linked jupyter setupbase:
# If we're an sdist, we aren't a repo and everything should be present.
# Don't rebuild js/css in that case.
In Fedora, all sources should be in its preferred form (i.e., editable by someone without going through hoops). That means non-minified sources. Ideally, the minified form should be generated from that source as well during package builds, but that's not always the case.
Activity
anntzer commentedon May 9, 2018
Would it make sense to not vendor jquery in the repo, but
Right now jquery weights 1.3Mb; compare this with the baseline test images that weight ~50Kb each and that we are painstakingly trying to avoid adding to the repo.
WeatherGod commentedon May 9, 2018
anntzer commentedon May 9, 2018
Hence the "configurably (via e.g. environment variable) from a local path (to satisfy distro packager constraints)."
WeatherGod commentedon May 9, 2018
anntzer commentedon May 9, 2018
Installing the notebook from a source checkout requires bower/npm/whateverjs: https://jupyter-notebook.readthedocs.io/en/latest/contributing.html https://github.com/jupyter/notebook/blob/master/setupbase.py#L565
I'm basically advocating for the same model, but replacing all the relevant tooling by "download jquery".
Actually now that I think of it, for debian & friends the even simpler solution is to also bundle jquery in the sdists (they're building from a sdist, not from a checkout). See comment in linked jupyter setupbase:
dstansby commentedon Jul 26, 2018
Do we actually need the non-minimal version of jquery? It doesn't seem to be referenced anywhere else.
anntzer commentedon Jul 26, 2018
@tacaswell told me it's the debian packaging rules...
QuLogic commentedon Jul 26, 2018
In Fedora, all sources should be in its preferred form (i.e., editable by someone without going through hoops). That means non-minified sources. Ideally, the minified form should be generated from that source as well during package builds, but that's not always the case.
anntzer commentedon Jul 26, 2018
(I don't think #11246 is actually that hard to push to completion if anyone wants to take a stab at it...)
tacaswell commentedon Feb 18, 2019
This is addressed (via #13445 ).