Skip to content

Open CVE on vendored jquery #11199

Closed
Closed

Description

@msarahan

Bug report

Bug summary

Your vendored jquery is old and has a known security vulnerability, https://nvd.nist.gov/vuln/detail/CVE-2016-7103

Code for reproduction

Look at https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/backends/web_backend/jquery/js/jquery-1.11.3.js

Humble request

Please update your vendored jquery.

Activity

  1. added this to the v2.2.3 milestone on May 8, 2018
  2. anntzer commented on May 9, 2018

    @anntzer
    Contributor

    Would it make sense to not vendor jquery in the repo, but

    1. change setup.py so that it fetches jquery at build time, normally online but configurably (via e.g. environment variable) from a local path (to satisfy distro packager constraints).
    2. the sdist would not contain jquery but follow the same idea
    3. the wheels would contain jquery.

    Right now jquery weights 1.3Mb; compare this with the baseline test images that weight ~50Kb each and that we are painstakingly trying to avoid adding to the repo.

  3. WeatherGod commented on May 9, 2018

    @WeatherGod
    Member
  4. anntzer commented on May 9, 2018

    @anntzer
    Contributor

    Hence the "configurably (via e.g. environment variable) from a local path (to satisfy distro packager constraints)."

  5. WeatherGod commented on May 9, 2018

    @WeatherGod
    Member
  6. anntzer commented on May 9, 2018

    @anntzer
    Contributor

    Installing the notebook from a source checkout requires bower/npm/whateverjs: https://jupyter-notebook.readthedocs.io/en/latest/contributing.html https://github.com/jupyter/notebook/blob/master/setupbase.py#L565
    I'm basically advocating for the same model, but replacing all the relevant tooling by "download jquery".

    Actually now that I think of it, for debian & friends the even simpler solution is to also bundle jquery in the sdists (they're building from a sdist, not from a checkout). See comment in linked jupyter setupbase:

                    # If we're an sdist, we aren't a repo and everything should be present.
                    # Don't rebuild js/css in that case.
    
  7. added
    Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
    on May 14, 2018
  8. dstansby commented on Jul 26, 2018

    @dstansby
    Member

    Do we actually need the non-minimal version of jquery? It doesn't seem to be referenced anywhere else.

  9. anntzer commented on Jul 26, 2018

    @anntzer
    Contributor

    @tacaswell told me it's the debian packaging rules...

  10. QuLogic commented on Jul 26, 2018

    @QuLogic
    Member

    In Fedora, all sources should be in its preferred form (i.e., editable by someone without going through hoops). That means non-minified sources. Ideally, the minified form should be generated from that source as well during package builds, but that's not always the case.

  11. anntzer commented on Jul 26, 2018

    @anntzer
    Contributor

    (I don't think #11246 is actually that hard to push to completion if anyone wants to take a stab at it...)

  12. modified the milestones: v2.2.3, v2.2.4 on Aug 5, 2018
  13. tacaswell commented on Feb 18, 2019

    @tacaswell
    Member

    This is addressed (via #13445 ).

  14. removed their assignment
    on Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Release criticalFor bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions