Skip to content

broken link in lib/matplotlib/dates.py comment #10453

Closed

Description

@pseyfert

Bug report

Not really a bug in terms of misbehaving code. I was just trying to understand lib/matplotlib/dates.py and and found a link in a comment that lead nowhere.

268ca34#diff-e6ad13bbdbf1912ae565e5ed7f274144R515

https://bugs.python.org/issue177742

The code just says

if dt.year >= 1900:
    # Note: in python 3.3 this is okay for years >= 1000,
    # refer to http://bugs.python.org/issue177742
    return cbook.unicode_safe(dt.strftime(fmt))

Expected outcome

The link leads to an existing bug which can then be read.

Matplotlib version

Cloned the current master, e.g. 86514a2, but also in matplotlib 2.0.0

Activity

  1. jenshnielsen commented on Feb 14, 2018

    @jenshnielsen
    Member

    I would guess that the correct issue is https://bugs.python.org/issue1777412

  2. pseyfert commented on Feb 14, 2018

    @pseyfert
    ContributorAuthor

    Thanks, that looks correct indeed.

    (I realised now I could've found that #3242 (comment) in the discussion of the merge request that added the comment).

    Should I make a tiny PR that adds the missing digit?

  3. added a commit that references this issue on Feb 14, 2018
    9c475c6
  4. tacaswell commented on Feb 14, 2018

    @tacaswell
    Member

    @pseyfert Yes please!

  5. added this to the v2.2.1 milestone on Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions