Remove unnecessary special handling for colons in paths.

anntzer · anntzer · commit 80cfa20bd5a0 · 2019-08-13T15:48:50.000+02:00
diff --git a/doc/sphinxext/missing_references.py b/doc/sphinxext/missing_references.py
@@ -95,41 +95,28 @@ def get_location(node, app):
     has injected text into the sphinx parsing engine).
     """
     (path, line) = get_source_line(node)
-
     if path:
-        # sometimes the 'path' can contain ':' which are forbidden on
-        # windows, but on posix just passes through.
-        path, *post = path.partition(':')
-        post = ''.join(post)
-        # We locate references relative to the parent of the doc
-        # directory, which for matplotlib, will be the root of the
-        # matplotlib repo. When matplotlib is not an editable install
-        # weird things will happen, but we can't totally recover from
-        # that.
+        # We locate references relative to the parent of the doc directory,
+        # which for matplotlib, will be the root of the matplotlib repo. When
+        # matplotlib is not an editable install weird things will happen, but
+        # we can't totally recover from that.
         basepath = Path(app.srcdir).parent.resolve()
-
         fullpath = Path(path).resolve()
-
         try:
             path = fullpath.relative_to(basepath)
         except ValueError:
-            # Sometimes docs directly contain e.g. docstrings
-            # from installed modules, and we record those as
-            # <external> so as to be independent of where the
-            # module was installed
+            # Sometimes docs directly contain e.g. docstrings from installed
+            # modules, and we record those as <external> so as to be
+            # independent of where the module was installed.
             path = Path("<external>") / fullpath.name
-
         # Ensure that all reported paths are POSIX so that docs
         # on windows result in the same warnings in the JSON file.
         path = path.as_posix()
-
     else:
         path = "<unknown>"
-        post = ''
     if not line:
         line = ""
-
-    return f"{path}{post}:{line}"
+    return f"{path}:{line}"
 
 
 def _truncate_location(location):
