Repository navigation
ENH: work around pending deprecation warnings in MPL - #86
Merged
Merged
Conversation
Contributor
Author
|
reprod: run # t.py
import cmoceanon the master branch + matplotlib 3.6, it fails with on this branch it runs fine |
Contributor
|
Hi @neutrinoceros and thanks so much for your work on this! I'm not sure about what Python version we should support. I see this page from matplotlib which shows 3.8 is fine for the recent matplotlib version, but not the last one.
I think it is fine to follow matplotlib's lead and for the newest version of cmocean, support Python 3.8 as a minimum version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #83
notes:
packaging(which is extremely common, well distributed and maintained) as a dependency.importlib.metadata, but I can keep compatibility with older Python 3 version if desired, it's just a marginal ammount of additional work to leverage the backportimportlib_metadata.