Make sure tagName exists before using it. (mathjax/MathJax#3461) #1386
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1386 +/- ##
==========================================
Coverage 86.66% 86.66%
==========================================
Files 338 338
Lines 84384 84384
Branches 4779 3149 -1630
==========================================
Hits 73131 73131
Misses 11253 11253 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error where clicking on the
mjx-breakelement used to allow in-line line breaks causes an error from MathJax. It was due to treating the#textchild of themjx-breakelement as anHTMLElementby assuming that it has atagName. The fix is to check thattagNameexists before using it.Resolves issue mathjax/MathJax#3461.