Chrome 135 - #1
Open
mathhulk wants to merge 44 commits into
Open
Conversation
Also implements common keyboard shortcuts on Mac.
Also adds methods to dynamically set/get the frame rate and fixes some pre-existing compile issues.
- Detailed test: Don't display error for frames other than main frame
Added root_cache_path setting and onAlreadyRunningAppRelaunch event to deal with new CEF restrictions regarding parallel use of root_cache_path dir starting with CEF 120.
Frame identifiers change from long to String.
Method names should follow Java naming conventions.
Disabled signal handlers on POSIX systems and removed the previous signal handler fix.
This adapts JCEF to a significant change in CEF: the removal of the Alloy Bootstrap. It makes JCEF use the Alloy Runtime mode for "normal" browser windows (because Chrome-style windows can't be integrated into existing native parents, which is how JCEF integrates browsers into Java UI) and changes the DevTools handling to open the DevTools in a separate pop-up window. The latter is necessary because DevTools are unsupported in an Alloy-style window by CEF at the moment, thus it's no longer possible to integrate the DevTools into Java windows.
Removed static sandbox linking code from build scripts due to static sandbox lib removal in CEF. Sandbox must now be loaded dynamically, but JCEF does not currently support sandbox mode anyway.
This upgrades the JCEF wrapper classes for CefResourceHandler to also include the newer Open/Skip/Read API. The new API methods have been added in addition to the old ProcessRequest/ReadResponse methods in the same way as this was done in the original CEF interface, thereby allowing for the same backwards compatibility to be provided by default, while enabling JCEF-based applications to use the new API in order to implement features that the old API doesn't allow for, such as correct handling of Range requests.
Java 17+ restricts access to internal sun.* APIs. The app needs JVM flags to open these modules.
JOGL's DestroyNSWindow0 is called from SharedResourceRunner thread during OpenGL capability detection cleanup. macOS requires NSWindow operations on the main thread, causing a crash: "Must only be used from the main thread" Patch OSXUtil.DestroyNSWindow in jogl-all.jar to dispatch via RunOnMainThread when called from a background thread, matching how CreateNSWindow is already handled. The issue includes a script for applying this patch to the original 2.4.0 jar version. Related bug: https://jogamp.org/bugzilla/show_bug.cgi?id=1370
Use performSelector:onThread:withObject:waitUntilDone:modes: with both NSDefaultRunLoopMode and NSEventTrackingRunLoopMode to ensure CEF's message loop work is processed during modal operations like window resize and close.
Updated to CEF 146.0.10+g8219561+chromium-146.0.7680.179. Synchronized CefLoadHandler.ErrorCode and its JNI mapping with the CEF 146 error list by removing error codes that are now obsolete upstream and no longer produced by CEF. In line with previous JCEF releases, the obsolete code was removed rather than left commented out. Ran a smoke test with the 'detailed' sample. Also integrated a build based on this branch into our own software and ran some tests, no issues encountered.
|
@mathhulk I noticed your involvement in the Chrome 135 pull request and your expertise with TypeScript. Your ability to push boundaries in web development aligns well with my current project needs. I'm impressed by your focus on trust in user interactions, particularly in your top repo. I'm looking for a part-time contributor who can assist with my business, which offers a good side income. If interested, please contact via this email: hector624@proton.me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.