Skip to content

add options chain endpoint#352

Merged
antdjohns merged 4 commits into
masterfrom
options-chain
Jan 5, 2023
Merged

add options chain endpoint#352
antdjohns merged 4 commits into
masterfrom
options-chain

Conversation

@antdjohns

Copy link
Copy Markdown
Contributor

Endpoint and tests added to python client.

@mmoghaddam385 mmoghaddam385 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comment things, but otherwise LGTM. We probably shouldn't merge this until the API is released 👍

Comment thread polygon/rest/snapshot.py Outdated
Comment thread polygon/rest/snapshot.py Outdated
@antdjohns antdjohns marked this pull request as ready for review January 4, 2023 20:11
@antdjohns antdjohns requested a review from jbonzo as a code owner January 4, 2023 20:11
Comment thread polygon/rest/snapshot.py Outdated
@jbonzo

jbonzo commented Jan 4, 2023

Copy link
Copy Markdown
Collaborator

We are good to merge

@antdjohns antdjohns merged commit 425bdd4 into master Jan 5, 2023
@antdjohns antdjohns deleted the options-chain branch January 5, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants