Skip to content

AC-8877: terraform/stack setup fails with broken pip dependency #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iankigen merged 1 commit into from
Jun 3, 2021
Merged

AC-8877: terraform/stack setup fails with broken pip dependency #4

iankigen merged 1 commit into from
Jun 3, 2021

Conversation

@shanbady
Copy link

@shanbady shanbady commented May 28, 2021

This fixes an issue preventing the 'setup' command to fail from opsworks.

to test -

  • we have a few broken stacks in opsworks (indicated by the red for example test-30). choose one and run 'setup'.
  • note that running setup fails.
  • go to stack settings and change the branch to 'test-buildout-fix'. this is a branch in the opsworks-web-deploy repo that is preconfigured to point to this branch for the python cookbooks.

Screen Shot 2021-05-28 at 11 06 19

- run the 'update custom cookbooks' command on the stack - once that completes re-run setup - note that it succeeds

@shanbady
Copy link
Author

shanbady commented Jun 1, 2021

note: this project never had a working travis build. it is not expected to pass.

@philophilo philophilo self-assigned this Jun 2, 2021
@iankigen iankigen self-assigned this Jun 2, 2021
iankigen
iankigen approved these changes Jun 2, 2021
View reviewed changes
Copy link

@iankigen iankigen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes/QA looks good
Steps:

  • update stack.tf revision to "test-buildout-fix" && make create-aws-stack stack=ian tag=v1.4.30
  • run the 'update custom cookbooks' command on the stack ✅ - stack instance status = online

philophilo
philophilo approved these changes Jun 3, 2021
View reviewed changes
Copy link

@philophilo philophilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

  • The deployment was successful

@iankigen iankigen merged commit 13019f0 into master Jun 3, 2021
@iankigen iankigen deleted the AC-8877 branch June 3, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iankigen iankigen iankigen approved these changes

+1 more reviewer

@philophilo philophilo philophilo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@philophilo philophilo

@iankigen iankigen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shanbady @philophilo @iankigen