Skip to content

Commit 025fefd

Browse files
markusfoomarkusfoo
committed
fix(ci): check out repo in build-pecl so patch scripts resolve
The build-pecl job runs $GITHUB_WORKSPACE/.github/patches/fix_redis_library_nul.py to NUL-terminate phpredis decompressed buffers (PHP >= 8.6 json scanner EOI), but the job never checked out this repository, so on the runner the script did not exist and the job died right after the igbinary prebuild with: python3: can't open file '.github/patches/fix_redis_library_nul.py': No such file or directory (seen on the php-8.6.0beta3 run). The build-redis workflow is not affected because it does have a checkout step. Add an actions/checkout step at the top of build-pecl, mirroring the "Check out this repo" step the smoke-test job already uses. The patch script itself is committed and verified to still apply cleanly against current phpredis develop (lzf/zstd/lz4 anchors each match exactly once).
1 parent bb62bde commit 025fefd

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

‎.github/workflows/build-php.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -542,6 +542,11 @@ jobs:
542542
runs-on: ubuntu-22.04
543543
timeout-minutes: 60
544544
steps:
545+
# PECL sources are patched by scripts committed to this repo
546+
# (.github/patches/), so this job needs an actual checkout.
547+
- name: Check out this repo (for .github/patches/)
548+
uses: actions/checkout@v7
549+
545550
- name: Download built PHP .deb files
546551
uses: actions/download-artifact@v7
547552
with:

0 commit comments

Comments
 (0)