Repository navigation
Conversation
1 task done
Contributor
|
Build artifacts for PR #5885: Run: https://github.com/marktext/marktext/actions/runs/40196857636
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5884
Summary
On Windows, opening Edit still shows two separators between Find in Folder and Line Ending, even after #4797. That fix sets
visible: falseon the separator following the macOS-only Screenshot item, but Chromium'sSimpleMenuModel::IsVisibleAtbypasses command visibility for separators. The existing test filtered out hidden separators itself, so it missed the native behavior.Build the Screenshot item and its trailing separator only on macOS. Windows/Linux now receive exactly one separator between Find in Folder and Line Ending; macOS retains the Screenshot item, shortcut, handler, and surrounding separators.
Update the regression coverage to account for native separator visibility, assert the exact Windows/Linux section, and preserve the macOS section.
Type of change
Test plan
edit-menu-separator,edit-menu-native-clipboard-roles-5582,application-menu-state, andreading-mode.pnpm run typecheckpnpm run lint(0 errors; 166 existing warnings)git diff --checkNotes for reviewers
Validation ran on macOS, with platform-specific menu configuration mocked in the unit tests. The visibility check models Chromium's native separator handling; it does not claim a Windows GUI run. A Windows environment was unavailable, so there is no Windows screenshot or recording.
The related suites were run with a temporary Vite
server.fs.allowoverride because this worktree reuses dependencies through symlinks to another checkout. No repository test configuration was changed.Native behavior reference: Chromium SimpleMenuModel::IsVisibleAt, where separator visibility uses the native item's visibility rather than
Delegate::IsCommandIdVisible.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.