Repository navigation
fix: align rectangular task markers with text - #5700
Merged
Merged
Conversation
Contributor
|
Build artifacts for PR #5700: Run: https://github.com/marktext/marktext/actions/runs/38119452554
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: none found; reported with screenshots during local validation.
Summary
Rectangular task markers in Ulysses, Graphite, and One Dark sit above the first text line because their top offset uses
0.1em; native inputs retain their browser font size. Center the 16px markers using the editor font-size and line-height variables, and use the logical inline inset consistently.Apply Graphite and One Dark styles to both input and span markers so both DOM representations render the same square shape and checked state.
Before: checked and unchecked squares sit above the text center. After: both align with the first line as editor typography changes.
Type of change
Test plan
git diff --checkpassed.pnpm run lintblocked: ESLint cannot resolveglobals.pnpm run typecheckblocked: E2E specs cannot resolveplaywright, with resulting implicit-any errors.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.