Skip to content

fix: align rectangular task markers with text - #5700

Merged
Jocs merged 1 commit into
developfrom
fix/rectangular-task-marker-alignment
Oct 11, 2026
Merged

Jocs merged 1 commit into
developfrom
fix/rectangular-task-marker-alignment

Conversation

@Jocs

@Jocs Jocs commented Oct 11, 2026

Copy link
Copy Markdown
Member

Related issue: none found; reported with screenshots during local validation.

Summary

Rectangular task markers in Ulysses, Graphite, and One Dark sit above the first text line because their top offset uses 0.1em; native inputs retain their browser font size. Center the 16px markers using the editor font-size and line-height variables, and use the logical inline inset consistently.

Apply Graphite and One Dark styles to both input and span markers so both DOM representations render the same square shape and checked state.

Before: checked and unchecked squares sit above the text center. After: both align with the first line as editor typography changes.

Type of change

  • Bug fix (non-breaking, fixes an issue)
  • New feature (non-breaking, adds functionality)
  • Breaking change (causes existing functionality to change)
  • Documentation update

Test plan

  • New tests added: CSS-only positioning change; visual verification required.
  • Manually tested on macOS: dev app launched for user validation; final cross-theme validation pending.
  • git diff --check passed.
  • Prettier reports only existing float-shadow formatting in these files.
  • pnpm run lint blocked: ESLint cannot resolve globals.
  • pnpm run typecheck blocked: E2E specs cannot resolve playwright, with resulting implicit-any errors.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@github-actions

Copy link
Copy Markdown
Contributor

Build artifacts for PR #5700:

Run: https://github.com/marktext/marktext/actions/runs/38119452554

Artifact Size Link
marktext-windows-x64 296.5 MB Download
marktext-macos-arm64 297.6 MB Download
marktext-macos-x64 310.9 MB Download
marktext-linux 660.8 MB Download
marktext-windows-arm64 288.3 MB Download

@Jocs
Jocs merged commit fbdff9c into develop Oct 11, 2026
11 checks passed
@Jocs
Jocs deleted the fix/rectangular-task-marker-alignment branch October 11, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant