Repository navigation
chore(desktop): disable the Report button in the error dialog - #5359
Merged
Merged
Conversation
The unexpected-error dialog's Report button opened a GitHub issue prefilled with only the stack trace. Those reports rarely include reproduction steps and have flooded the issue tracker (e.g. #5356), so comment the button and its handler out. OK and Copy error stay. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JLExVPhcFJomRqWH47diMu
Contributor
|
Build artifacts for PR #5359: Run: https://github.com/marktext/marktext/actions/runs/34914220221
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Unexpected main/renderer process error" dialog had a Report button that opened
issues/newprefilled with the stack trace (titleUnexpected error with message …, body with a placeholder for reproduction steps). Almost none of those reports include steps, and they arrive faster than they can be triaged — e.g. #5356.This PR comments out that entry point in
packages/desktop/src/main/exceptionHandler.ts:error.reportbutton is removed from the dialog, which now offers only OK and Copy error;case 2handler that built and opened the prefilled issue URL, and itscreateAndOpenGitHubIssueUrlimport, are commented out.utils/createGitHubIssue.tsand theerror.report/error.unexpectedErrorWithMessagelocale keys are left in place so the button can be restored by uncommenting. Help → Report Bug (which opens the issue list without a prefilled crash report) is unchanged.Refs #5356
Test plan
eslinton the changed filepnpm run typecheckvitest run test/unit/specs/exception-handler-output.spec.tsmt::handle-renderer-errorhandler shows a dialog with buttons[common.ok, error.copyError], and a response index of 2 does not callshell.openExternal🤖 Generated with Claude Code
https://claude.ai/code/session_01JLExVPhcFJomRqWH47diMu