Repository navigation
fix(release): add repository field for electron-builder - #4368
Merged
Merged
Conversation
After the monorepo split, electron-builder runs from packages/desktop/
where there is no sibling .git/ to auto-detect. Without an explicit
repository field, publish config inference returns null and
computeChannelNames crashes generating updater metadata:
TypeError: Cannot read properties of null (reading 'channel')
at computeChannelNames (app-builder-lib/.../updateInfoBuilder.ts:47)
Add the canonical repository entry so electron-builder can build the
GitHub publish config and produce latest.yml / latest-mac.yml as before.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Build artifacts for PR #4368: Run: https://github.com/marktext/marktext/actions/runs/26995181576
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the monorepo split (#4302), electron-builder runs from
packages/desktop/where there is no sibling.git/configto auto-detect the repo. Without an explicitrepositoryfield inpackages/desktop/package.json, publish-config inference returns null andcomputeChannelNamescrashes while generating updater metadata:#4361 restored local builds but didn't surface this because the crash happens in the updater-metadata path, not the install path.
This adds the canonical GitHub
repositoryentry. Cherry-picked from therelease/v0.19.1branch — validated by the v0.19.1 release run that now produceslatest.yml/latest-mac.yml/latest-linux.ymlcorrectly across all 5 platforms.Test plan
release/v0.19.1branch succeeded end-to-end with this fix (4 platforms first try + 1 ARM64 rerun for an unrelated flake; publish step generated all 24 expected assets)