Skip to content

Re-Factor MarkText with electron-vite #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 305 commits into
base: develop
Choose a base branch
from
Open

Re-Factor MarkText with electron-vite #4001

wants to merge 305 commits into from

Conversation

@Tkaixiang
Copy link

@Tkaixiang Tkaixiang commented Jul 20, 2025

Q A
Bug fix? yes
New feature? yes
Breaking changes? yes
Deprecations? yes
New tests added? N/A
Fixed tickets N/A
License MIT

Description

  • This is an attempt at a complete "re-factor" of MarkText by introducing a new development environment (electron-vite) to modernise the development process
    • Bundle size is 100MB smaller
  • Pretty much all libraries have been bumped up to their modern versions, with respective API changes
    • Most notable is moving away from Vue2 to Vue3 with the Composition API
  • Based off Jacob Whall's fork which already includes quite a number of bug fixes
  • Also includes Update keybindingsWindows.js - set binding to file.print #3859
  • Also includes some of my own QoL improvements
    • Better handling of bullet points when repeatedly pressing enter (now more in-line with what you will expect from popular text editors)
    • Tab switching now restores your scroll position to where you left of, instead of jumping to your cursor
      • Opening a file now lands you at the start rather than the end

jacobwhall and others added 30 commits February 15, 2023 20:01
@jacobwhall
merge branch 'develop' into trunk
f6625f1
@left0ver
fix: upload failure with github (marktext#3588)
9d741ea
@sukalaper
Add new documentation for Arch Linux user.
9232436
Fixed CVE-2023-2318
e83b8a5
@sukalaper
Fixed incorrect commas.
c89490a
@jacobwhall
Merge remote-tracking branch 'left0ver/develop' into trunk
3648c63
@jacobwhall
Merge remote-tracking branch 'sukalaper/sukalaper' into trunk
4d0ebbd
@jacobwhall
update README.md
25c2406
@jacobwhall
Merge remote-tracking branch 'marktext/fix-not-colored-icons-windows'…
df09438 
… into trunk
@jacobwhall
Merge remote-tracking branch 'marktext/fix-3150-win32-io-error' into …
671ce2f 
…trunk
@jacobwhall
update Contributor Covenant to version 2.1
baa05bc
@jacobwhall
merge remote-tracking branch 'Teloshav/hotfix-v0.17.1'
3038d5c
@jacobwhall
fix variable reference when sanitizing text
9707db7
@jacobwhall
Merge pull request #8 from jacobwhall/fix-CVE-2023-2318
8660be3 
Fix security vulnerability CVE-2023-2318
@jacobwhall
Add install instructions to README.md
e595b26
@jacobwhall
update project links in help menu
89967fa
@jacobwhall
remove undraw placeholder images
a5765d8
@jacobwhall
match color of message to theme when no tabs are open
f437e10
@jacobwhall
minor formatting adjustments to menu labels
d8d470c
@jacobwhall
remove redundant colons in export settings dialogue
5ceea60
@jacobwhall
bump version to 0.17.4
e2815be
@jacobwhall
remove disused files from .github/
01e6922
@jacobwhall
add plea for contributions to README.md
afb7b6d
@cramaker @jacobwhall
Update BUILD.md
5fcfc1b 
Add `rpm` package as a dependency on Debian systems
@ivy-rew
upgrade to mermaid 10
2b9803c 
with 'mindmap' support
@jacobwhall
update build instructions
7a27a81
@jacobwhall
Merge pull request #25 from ivy-rew/mermaid106
3c61087 
upgrade mermaid to 10.6.1
@jacobwhall
bump version to 0.17.5
a9868ab 
- oops! forgot to do this before.
@bertstomphorst
Update keybindingsWindows.js - set binding to file.print
a160598 
In file.print on Windows, keybinding Ctrl+P is pretty common, so I mapped it.
test
7b7b247
Tkaixiang added 30 commits October 2, 2025 18:12
@Tkaixiang
ignore .min.json
726a487
@Tkaixiang
ignore minified files
eaa00a0
@Tkaixiang
Change copy-paste to not copy file:// protocol when copying images
c707242
@Tkaixiang
Fix some bugs with image paths when exporting
589dd70
@Tkaixiang
Fix bug when zooming
081486b
@Tkaixiang
Fix link bugs
9ce850e
@Tkaixiang
Fix ipcRenderer.emit calls
30b25d6
@Tkaixiang
Fix small bug with unloading listenerer
265260d
@Tkaixiang
Fix command palette + focus after open
b433154
@Tkaixiang
Add tar.gz back to linux build targets
8f01b9c
@Tkaixiang
rename to .mjs for support with older node versions
e1f7b75
@Tkaixiang
Fix bug with numbered lists (now behaves similarly to unordered lists)
698dea0
@Tkaixiang
Fix pasting of code into codeblocks on windows
f1d3a07
@Tkaixiang
Update auto report template
89d03fc
@Tkaixiang
a
3c55c5c
@Tkaixiang
Fix image in link rendering error
304107a
@Tkaixiang
Add some fallbacks for preserving this.blocks state in case of an error
4398444
@Tkaixiang
Preserve relative paths of images when copying
5195b57
@Tkaixiang
Improve image copying + pasting
8d08ffc
@Tkaixiang
normalise windows paths
7790f79
@Tkaixiang
Update to not automatically normalise
5f5b290
@Tkaixiang
Fix drag and drop images
24fb227
@Tkaixiang
Add more safeguards for paths with spaces
eeae588
@Tkaixiang
1 more safeguard
655bb1f
@Tkaixiang
Ensure nothing is fetched during clean-up
9905f18
@Tkaixiang
Fix a bug where blocks is sometimes not the most updated blocks state…
2d83dfb 
… + fix a bug with cursor position when switching between code editor/WYSIWIG
@Tkaixiang
Fix blocks saving again - now truly on tab switch ONLY
2b5876b
@Tkaixiang
Finally fixed blocks - turns out issue was a lack of dispatchChange i…
fc9c7b4 
…n cut controller
@Tkaixiang
Fix duplicate CLOSE_TAB
878e24a
@Tkaixiang
Added a small debounce for search to avoid extreme lag
af557f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.