Skip to content

feat[menu]support upload image in menu #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat[menu]support upload image in menu #3319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 31 additions & 24 deletions src/main/contextMenu/editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import {
PASTE_AS_PLAIN_TEXT,
SEPARATOR,
INSERT_BEFORE,
INSERT_AFTER
INSERT_AFTER,
UPLOAD_IMAGE
} from './menuItems'
import spellcheckMenuBuilder from './spellcheck'

Expand All @@ -27,28 +28,34 @@ export const showEditorContextMenu = (win, event, params, isSpellcheckerEnabled)
// `webFrame.isWordMisspelled` doesn't work on Windows (Electron#28684).

// Make sure that the request comes from a contenteditable inside the editor container.
if (isInsideEditor(params) && !hasImageContents) {
const hasText = selectionText.trim().length > 0
const canCopy = hasText && editFlags.canCut && editFlags.canCopy
// const canPaste = hasText && editFlags.canPaste
const isMisspelled = isEditable && !!selectionText && !!misspelledWord

const menu = new Menu()
if (isSpellcheckerEnabled) {
const spellingSubmenu = spellcheckMenuBuilder(isMisspelled, misspelledWord, dictionarySuggestions)
menu.append(new MenuItem({
label: 'Spelling...',
submenu: spellingSubmenu
}))
menu.append(new MenuItem(SEPARATOR))
}

[CUT, COPY, COPY_AS_HTML, COPY_AS_MARKDOWN].forEach(item => {
item.enabled = canCopy
})
CONTEXT_ITEMS.forEach(item => {
menu.append(new MenuItem(item))
})
menu.popup([{ window: win, x: event.clientX, y: event.clientY }])
const inside = isInsideEditor(params)
if (!inside) return
const hasText = selectionText.trim().length > 0
const canCopy = hasText && editFlags.canCut && editFlags.canCopy
// const canPaste = hasText && editFlags.canPaste
const isMisspelled = isEditable && !!selectionText && !!misspelledWord

const menu = new Menu()
if (isSpellcheckerEnabled) {
const spellingSubmenu = spellcheckMenuBuilder(isMisspelled, misspelledWord, dictionarySuggestions)
menu.append(new MenuItem({
label: 'Spelling...',
submenu: spellingSubmenu
}))
menu.append(new MenuItem(SEPARATOR))
}

[CUT, COPY, COPY_AS_HTML, COPY_AS_MARKDOWN].forEach(item => {
item.enabled = canCopy
})
CONTEXT_ITEMS.forEach(item => {
menu.append(new MenuItem(item))
})
if (hasImageContents) {
// TODO implement upload-image buttons
// if (isLocalImage)
// menu.append(new MenuItem(UPLOAD_IMAGE))
}
menu.popup([{ window: win, x: event.clientX, y: event.clientY }])

}
8 changes: 8 additions & 0 deletions src/main/contextMenu/editor/menuItems.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,14 @@ export const INSERT_AFTER = {
}
}

export const UPLOAD_IMAGE = {
label: 'Upload Image',
id: 'uploadImageWithUserConfig',
click (menuItem, targetWindow) {
targetWindow.webContents.send('mt::cm-upload-image')
}
}

export const SEPARATOR = {
type: 'separator'
}