Fix mermaid diagram is not visiable when export html #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxha
requested changes
Nov 21, 2019
There was a problem hiding this comment.
This will show the document twice if you export a document. Please try this document with your change and you will notice that the exported HTML (.ag-render-container container) is visible while exporting. That's was the reason to hide the container.
Hide this container will cause render mermaid\flowchart incorrectly. So we need to put it out of viewport(off screen). |
|
@Jocs The content is visible again during export on latest develop/v0.16.0-rc2. E.g. export a document with multiple paragraphs and some math formulas. |
|
Maybe we can only use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Description of the bug or feature]
--
Please, don't submit
/distfiles with your PR!This change is