Skip to content

Fix application menu exceptions #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2019
Merged

Fix application menu exceptions #1437

merged 1 commit into from
Oct 4, 2019

Conversation

@fxha
Copy link
Contributor

@fxha fxha commented Oct 3, 2019

Q A
Bug fix? yes
BC breaks? yes
License MIT

Description

  • Fixed multiple potential main process exceptions because the application menu may be null. E.g. when creating a new editor window and focusing the settings window.
  • Fixed windowId type in renderer process
  • Fixed line ending menu item state when switching tabs
  • Breaking change: After creating a window the editor is either preview or source-code according settings but don't respect the last active editor window settings any more.

@fxha fxha requested a review from Jocs October 3, 2019 13:26
fxha
fxha commented Oct 3, 2019
View reviewed changes
@Jocs
Copy link
Member

Jocs commented Oct 4, 2019

@fxha I'll review #1437 #1438 this evening.

@Jocs Jocs merged commit 2c15d51 into develop Oct 4, 2019
@Jocs Jocs deleted the fix-application-menu branch October 4, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jocs Jocs Jocs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fxha @Jocs