Skip to content

Feat: add menu for tabs #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 12, 2019
Merged

Feat: add menu for tabs #1434

merged 3 commits into from
Oct 12, 2019

Conversation

@kenyx89
Copy link
Contributor

@kenyx89 kenyx89 commented Oct 2, 2019

Q A
Bug fix? no
New feature? yes
Fixed tickets #1369
License MIT

Description

Added menu for tabs.

--

Please, don't submit /dist files with your PR!

@kenyx89 kenyx89 closed this Oct 2, 2019
@kenyx89 kenyx89 reopened this Oct 2, 2019
@kenyx89 kenyx89 closed this Oct 2, 2019
@kenyx89 kenyx89 reopened this Oct 2, 2019
fxha
fxha reviewed Oct 2, 2019
View reviewed changes
@fxha fxha requested a review from Jocs October 2, 2019 22:04
Jocs
Jocs reviewed Oct 4, 2019
View reviewed changes
@Jocs
Copy link
Member

Jocs commented Oct 4, 2019 •
edited
Loading

@fxha @kenyx89 I recommend adding a menu item for the new tab and renaming show in file manager to show in folder so that each menu item is uniform in length.

@Jocs Jocs requested a review from fxha October 10, 2019 13:28
@kenyx89
Copy link
Contributor Author

kenyx89 commented Oct 10, 2019

@Jocs where will the New tab menu item be positioned?

@Jocs
Copy link
Member

Jocs commented Oct 10, 2019

where will the New tab menu item be positioned?

I found it's not necessary now, because I found there is already a + on the right of all tabs. thanks.

Jocs
Jocs reviewed Oct 10, 2019
View reviewed changes
@Jocs Jocs self-requested a review October 10, 2019 16:08
@fxha fxha merged commit 342e9c4 into marktext:develop Oct 12, 2019
@fxha
Copy link
Contributor

fxha commented Oct 12, 2019

Thanks @kenyx89

@mlantas mlantas mentioned this pull request Jul 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jocs Jocs Jocs approved these changes

@fxha fxha fxha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenyx89 @Jocs @fxha