MLE-17028 Fixing Polaris warnings - #1748
Merged
Merged
Conversation
Should take care of all highs and mediums.
rjrudin
force-pushed
the
feature/17208-polaris
branch
from
April 25, 2025 18:29
b9b437f to
9e0b0a3
Compare
BillFarber
reviewed
Apr 25, 2025
| Calendar fromDate = Calendar.getInstance(); | ||
| fromDate.setTime(row.getDate("from_date")); | ||
| s.put("fromDate", dateFormat.format(fromDate.getTime())); | ||
| s.put("fromDate", new SimpleDateFormat(ISO_8601_FORMAT).format(fromDate.getTime())); |
Contributor
There was a problem hiding this comment.
Seems weird that Polaris wants you to create this object every time.
BillFarber
approved these changes
Apr 25, 2025
BillFarber
left a comment
BillFarber
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but tough to be sure with the current server Optic bug.
Contributor
Author
|
All good now, Optic bug was fixed in the server and only failure is an intermittent DMSDK one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should take care of all highs and mediums.