Can now specify SSL Protocol when creating a CertificateAuthContext. - #1743
Merged
Merged
Conversation
rjrudin
requested changes
Apr 2, 2025
rjrudin
left a comment
rjrudin
left a comment
Contributor
There was a problem hiding this comment.
The other step is to make DatabaseClientPropertySource use the value of sslProtocol when it creates a CertificateAuthContext. newCertificateAuthContext will need that value so it can pass it into the constructor.
rjrudin
reviewed
Apr 2, 2025
BillFarber
force-pushed
the
task/sslImprovements
branch
from
April 3, 2025 13:05
1be2820 to
dd5b2b8
Compare
rjrudin
requested changes
Apr 3, 2025
BillFarber
force-pushed
the
task/sslImprovements
branch
from
April 3, 2025 14:13
dd5b2b8 to
747a0f4
Compare
rjrudin
requested changes
Apr 3, 2025
rjrudin
left a comment
rjrudin
left a comment
Contributor
There was a problem hiding this comment.
Sorry, one more tweak for clarity.
BillFarber
force-pushed
the
task/sslImprovements
branch
from
April 3, 2025 14:48
747a0f4 to
cfd9ea8
Compare
rjrudin
previously approved these changes
Apr 3, 2025
BillFarber
force-pushed
the
task/sslImprovements
branch
from
April 3, 2025 14:50
cfd9ea8 to
219edf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure what else, if anything, needs to be done for https://progresssoftware.atlassian.net/browse/MLE-19397