Skip to content

Fixing bug where a 'naked' properties fragment cannot be written - #1661

Merged
rjrudin merged 1 commit into
developfrom
feature/null-content-writeBatcher
May 14, 2024
Merged

Fixing bug where a 'naked' properties fragment cannot be written#1661
rjrudin merged 1 commit into
developfrom
feature/null-content-writeBatcher

Conversation

@rjrudin

@rjrudin rjrudin commented May 1, 2024

Copy link
Copy Markdown
Contributor

The check on content being null was overly restrictive, as v1/documents allows for null content. This may cause some other DMSDK test to fail, in which case that test will be modified as null content is allowable here.

@rjrudin
rjrudin requested review from BillFarber and anu3990 as code owners May 1, 2024 19:44
BillFarber
BillFarber previously approved these changes May 1, 2024

@BillFarber BillFarber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending test fix

The check on content being null was overly restrictive, as v1/documents allows for null content. This may cause some other DMSDK test to fail, in which case that test will be modified as null content is allowable here.
@rjrudin
rjrudin force-pushed the feature/null-content-writeBatcher branch from c0c7837 to 796f0d0 Compare May 1, 2024 21:08
@rjrudin
rjrudin requested a review from BillFarber May 6, 2024 15:09
@rjrudin
rjrudin merged commit 67f1c6e into develop May 14, 2024
@rjrudin
rjrudin deleted the feature/null-content-writeBatcher branch May 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants