DEVEXP-650 Fixing search that includes metadata values - #1622
Merged
Conversation
BillFarber
reviewed
Nov 29, 2023
| while (page.hasNext()) { | ||
| DocumentRecord record = page.next(); | ||
| assertEquals("/metadata/test.xml", record.getUri()); | ||
| } |
Contributor
There was a problem hiding this comment.
Would it be worth asserting that the metadataValue was returned?
Need to use "toString()" instead of "name()" so that "metadatavalues" is converted into "metadata-values". This works fine for reading documents but not for searching documents.
rjrudin
force-pushed
the
feature/650-metadatavalues-fix
branch
from
November 29, 2023 23:58
2583f06 to
9c4b4c1
Compare
BillFarber
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to use "toString()" instead of "name()" so that "metadatavalues" is converted into "metadata-values". This works fine for reading documents but not for searching documents.