Skip to content

Extend timeout to render_component() #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markfinger merged 1 commit into from
Feb 28, 2017
Merged

Extend timeout to render_component() #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions react/render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from .render_server import render_server


def render_component(path, props=None, to_static_markup=False, renderer=render_server, request_headers=None):
def render_component(path, props=None, to_static_markup=False, renderer=render_server, request_headers=None, timeout=None):
if not os.path.isabs(path):
abs_path = staticfiles.find(path)
if not abs_path:
Expand All @@ -14,4 +14,4 @@ def render_component(path, props=None, to_static_markup=False, renderer=render_s
if not os.path.exists(path):
raise ComponentSourceFileNotFound(path)

return renderer.render(path, props, to_static_markup, request_headers)
return renderer.render(path, props, to_static_markup, request_headers, timeout=timeout)
5 changes: 1 addition & 4 deletions react/render_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@ def __unicode__(self):


class RenderServer(object):
def render(
self, path, props=None, to_static_markup=False, request_headers=None,
timeout=None
):
def render(self, path, props=None, to_static_markup=False, request_headers=None, timeout=None):
Copy link
Owner

@markfinger markfinger Feb 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉 thanks for that

url = conf.settings.RENDER_URL

if props is not None:
Expand Down