Move occurredOn to StoredEvent#85
Merged
Merged
Conversation
28 tasks
marein
added a commit
that referenced
this pull request
Mar 5, 2023
Replace the static clock with the official clock interface (PSR-20). The static Gaming\Common\Clock\Clock is since refactoring from #85 no longer so deep in the callstack that an implicit dependency is worthwhile. Thus it is completely replaced by PSR-20.
Merged
marein
added a commit
that referenced
this pull request
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is part of #79.
This pull request deletes all tests for every single domain event. They were time consuming to maintain anyway. They should be tested as soon as they are flushed from the aggregate within their tests. This needs to be done either here or in a separate pull request.