Improve logging and cleanup when ConnectionThread failes#91
Merged
marcoskirsch merged 4 commits intomarcoskirsch:masterfrom Jun 1, 2017
Merged
Conversation
close connection on coroutine errors and improve logging around closieg connections. Release memory warlier
…BetterLoggingAndMoreCloseConnections
marcoskirsch
approved these changes
Jun 1, 2017
httpserver.lua
Outdated
| fileServeFunction(bufferedConnection, req, args) | ||
| -- The bufferedConnection may still hold some data that hasn't been sent. Flush it before closing. | ||
| if not bufferedConnection:flush() then | ||
| log(connection, "closing connetion", "no (more) data") |
httpserver.lua
Outdated
| if not status then log(connection:getpeer(), "Error: " .. err) end | ||
| if not status then | ||
| log(connection, "Error: "..err) | ||
| log(connection, "closing connetion", "error") |
httpserver.lua
Outdated
| end | ||
|
|
||
| local function onDisconnect(connection, payload) | ||
| print("disconnected") |
Owner
There was a problem hiding this comment.
no big deal but maybe leave this commented out
Contributor
Author
There was a problem hiding this comment.
hmm this is only printed if the client disconnects, so to get the bracket open / close I like it.
But I can still take it out
Contributor
Author
|
There you go :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the connection Thread fials (status error)
the thread and the connection are cleaned up properly.